Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unimplemented hash to curve #32

Closed
GhostOfGauss opened this issue Mar 28, 2023 · 2 comments
Closed

Unimplemented hash to curve #32

GhostOfGauss opened this issue Mar 28, 2023 · 2 comments

Comments

@GhostOfGauss
Copy link

Currently the halo2 CurveExt trait is not fully implemented except for the pasta curves. The missing function hash_to_curve is unimplemented (see here). The implementation for pasta curves (here) makes use of an algorithm valid only for curves with a*b = 0 (see here). This implementation should therefore work for bn256 and secp256k1, which both have a = 0.

My first attempt to copy-paste the pasta implementation over gets stuck on the alloc dependency. Once that's figured out I'd be happy to open a PR

@eldenpark
Copy link

I'd also like to know how this is going to be handled. Have you made any progress w/ that alloc feature? @GhostOfGauss

@han0110
Copy link
Contributor

han0110 commented Jul 18, 2023

Replaced by #70

@han0110 han0110 closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants