Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Upgrade Ethers to 2.0.7 and boundary control #1451

Closed
ChihChengLiang opened this issue Jun 5, 2023 · 2 comments · Fixed by #1452
Closed

Upgrade Ethers to 2.0.7 and boundary control #1451

ChihChengLiang opened this issue Jun 5, 2023 · 2 comments · Fixed by #1452
Assignees
Labels
T-feature Type: new features

Comments

@ChihChengLiang
Copy link
Collaborator

Describe the feature you would like

We currently use the 0.17.0 version of ethers-rs crate, which is old and contains unmaintained parity dependencies.

Upgrading to the latest version 2.0.7 can let us use the latest update like withdrawal root in the block.

In addition to upgrading packages directly, It is also desirable to build a boundary for third-party, so that our codebase doesn't depend on them directly. If some new features we want and some incompatibility we don't want are both released in a new version, we can build a wrapper for it and control the behavior of the third-party package. I'm not sure if boundary control is really desirable or what degree of it is optimal, so let me present 3 prs for us to choose.

Additional context

No response

@ChihChengLiang
Copy link
Collaborator Author

I've presented three options in #1452, #1453, and #1454. Let me know your preferences.

@ChihChengLiang
Copy link
Collaborator Author

No feedback was given in the last month. We should favor the most simple one #1452

@ChihChengLiang ChihChengLiang linked a pull request Jul 4, 2023 that will close this issue
1 task
@ChihChengLiang ChihChengLiang added this to the Feature Completeness milestone Jul 4, 2023
github-merge-queue bot pushed a commit that referenced this issue Jul 7, 2023
### Description

Change ethers-rs related packages from 0.17.0 to 2.0.7

### Issue Link

#1451

### Type of change

- [x] New feature (non-breaking change which adds functionality)

### Rationale

We need nothing more than simply upgrading the package.
@ChihChengLiang ChihChengLiang self-assigned this Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-feature Type: new features
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant