Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bench for bytecode circuit #807

Merged
merged 20 commits into from
Oct 9, 2022
Merged

Add bench for bytecode circuit #807

merged 20 commits into from
Oct 9, 2022

Conversation

smtmfft
Copy link
Contributor

@smtmfft smtmfft commented Sep 28, 2022 •
edited
Loading

Addressed one of #666

Others are on the way.

smtmfft and others added 16 commits September 19, 2022 07:18
add bytecode bench
8d36ab9 
Signed-off-by: smtmfft <smtmfft@taikocha.in>
code refine
f5540ca 
Signed-off-by: smtmfft <smtm@taiko.xzy>
fix lint
7423b8e 
Signed-off-by: smtmfft <smtm@taiko.xzy>
fix lint
2376ae7 
Signed-off-by: smtmfft <smtm@taiko.xzy>
fix typo
781e358 
Signed-off-by: smtmfft <smtm@taiko.xzy>
fix review comment
990a08c 
Signed-off-by: smtmfft <smtm@taiko.xzy>
fix lint
cc08f93 
Signed-off-by: smtmfft <smtm@taiko.xzy>
remove VAR and use max bytecode_len instead
2959046 
Signed-off-by: smtmfft <smtm@taiko.xzy>
fix byte code filling
93f6d5c 
Signed-off-by: smtmfft <smtm@taiko.xzy>
add public input benchmark test
405e307 
Signed-off-by: smtmfft <smtm@taiko.xzy>
fix review comments
ffea79c 
Signed-off-by: smtmfft <smtm@taiko.xzy>
Merge remote-tracking branch 'origin/main' into add-benches
6d34a55
fix merge conflict
1db70b9 
Signed-off-by: smtmfft <smtm@taiko.xzy>
clean Cargo.toml
7caf759 
Signed-off-by: smtmfft <smtm@taiko.xzy>
make PR clean
ef3931f 
Signed-off-by: smtmfft <smtm@taiko.xzy>
make PR clean
6a754b6 
Signed-off-by: smtmfft <smtm@taiko.xzy>
@smtmfft smtmfft requested a review from a team as a code owner September 28, 2022 03:18
@smtmfft smtmfft requested review from ChihChengLiang and removed request for a team September 28, 2022 03:18
@github-actions github-actions bot added crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements labels Sep 28, 2022
smtmfft and others added 2 commits September 28, 2022 11:18
@smtmfft
Merge branch 'main' into add-benches
f454fb8
fix lint
dbaa1be 
Signed-off-by: smtmfft <smtm@taiko.xzy>
ed255
ed255 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this circuit to the benchmarks :)

Don't forget to apply the clippy suggestions to make all the github actions pass.

@ed255 ed255 mentioned this pull request Oct 3, 2022
Closed
5 tasks
ChihChengLiang
ChihChengLiang approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smtmfft
Copy link
Contributor Author

smtmfft commented Oct 8, 2022

LGTM! Thanks for adding this circuit to the benchmarks :)

Don't forget to apply the clippy suggestions to make all the github actions pass.

sure, will fix soon

smtmfft and others added 2 commits October 8, 2022 11:35
@smtmfft
Merge branch 'main' into add-benches
335e157
fix clippy warning
5f4b4d4 
Signed-off-by: smtmfft <smtm@taiko.xzy>
@ChihChengLiang ChihChengLiang merged commit 52ebd55 into privacy-scaling-explorations:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

@ed255 ed255 ed255 approved these changes

Assignees
No one assigned
Labels
crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smtmfft @ChihChengLiang @ed255