Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing circuits to benchmarks #666

Closed
5 tasks done
ed255 opened this issue Aug 6, 2022 · 3 comments · Fixed by #980
Closed
5 tasks done

Add missing circuits to benchmarks #666

ed255 opened this issue Aug 6, 2022 · 3 comments · Fixed by #980
Assignees
Labels
crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member

Comments

@ed255
Copy link
Member

ed255 commented Aug 6, 2022

We have benchmark tests defined here:
https://github.com/privacy-scaling-explorations/zkevm-circuits/tree/main/circuit-benchmarks/src

We need to include the following circuits:

@xiaodino
Copy link
Contributor

We are working on it.

@ChihChengLiang
Copy link
Collaborator

@ed255 looks like all missing benches are done. Do we need exp circuit bench as in #980?

@ed255
Copy link
Member Author

ed255 commented Dec 12, 2022

@ed255 looks like all missing benches are done. Do we need exp circuit bench as in #980?

Thanks for reviewing this! We should have benches for all circuits. Let me extend this issue to include the Exp Circuit and once it's merged we can close this :)

@aguzmant103 aguzmant103 linked a pull request Dec 12, 2022 that will close this issue
jonathanpwang pushed a commit to axiom-crypto/zkevm-circuits that referenced this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants