Add benchmark test for Public Input circuit #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-circuit-benchmarks
Signed-off-by: smtmfft <smtm@taiko.xzy>
smtmfft
requested review from
davidnevadoc
and removed request for
ChihChengLiang
Brechtpd
approved these changes
Nov 9, 2022
ChihChengLiang
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
We have two reviews from @davidnevadoc and @Brechtpd now.
Approving to pass the github check.
5 tasks
GopherJ
pushed a commit
to dompute/zkevm-circuits
that referenced
this pull request
Sep 13, 2023
…bus-mapping (privacy-scaling-explorations#830) * tag modexp circuit * try fix native reminder * fix divmod * update MODEXPCONFIG_EACH_CHIP_ROWS * fix fmt * update assert_eq and refactor tests * fix test: enlarge keccak rows * add invalid input testcase in modexp * fix sub with overflow if modexp input bytes len greater than 192 --------- Co-authored-by: DreamWuGit <wwuwwei@126.com> Co-authored-by: kunxian xia <xiakunxian130@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses another one of #666