Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exp circuit bench #980

Merged
merged 6 commits into from
Dec 15, 2022
Merged

Add exp circuit bench #980

merged 6 commits into from
Dec 15, 2022

Conversation

SuccinctPaul
Copy link
Contributor

@SuccinctPaul SuccinctPaul commented Dec 12, 2022 •
edited
Loading

@github-actions github-actions bot added crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements labels Dec 12, 2022
@ChihChengLiang ChihChengLiang mentioned this pull request Dec 12, 2022
Closed
5 tasks
@aguzmant103 aguzmant103 linked an issue Dec 12, 2022 that may be closed by this pull request
Add missing circuits to benchmarks #666
Closed
5 tasks
@aguzmant103 aguzmant103 requested review from a team and ChihChengLiang and removed request for a team December 12, 2022 20:25
@aguzmant103
Copy link
Member

Added zk-evm-reviewer group as a reviewer. FYI @ChihChengLiang

ChihChengLiang
ChihChengLiang approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It worked locally on my device.

@aguzmant103 aguzmant103 merged commit 9400c62 into privacy-scaling-explorations:main Dec 15, 2022
@SuccinctPaul SuccinctPaul deleted the add-exp-circuit-bench branch December 15, 2022 12:45
noel2004 pushed a commit to noel2004/zkevm-circuits that referenced this pull request Nov 29, 2023
@kunxian-xia @silathdiir
add sanity check to make sure ComparatorChip only use cur() in RLP (p…
21f887d 
…rivacy-scaling-explorations#980)

Co-authored-by: Steven <asongala@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

Assignees
No one assigned
Labels
crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements
Projects
zkEVM Community Edition
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing circuits to benchmarks
3 participants
@SuccinctPaul @aguzmant103 @ChihChengLiang