Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting might take values #400

Open
martinthomson opened this issue Jan 18, 2023 · 0 comments
Open

Sorting might take values #400

martinthomson opened this issue Jan 18, 2023 · 0 comments

Comments

@martinthomson
Copy link
Member

martinthomson commented Jan 18, 2023 •
edited
Loading

Not sure if there's a reason these functions take a reference to sort_keys. It looks like the callers have an owned Vec anyways, and the upgrade functions want to take the raw input by value, so it may be possible to change the argument type to this function and get rid of this clone and several like it.

Originally posted by @andyleiserson in #396 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinthomson