-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in rollmean(): Parameter 'size' is too large. #2
Comments
bigutilsr::rollmean()
: Parameter 'size' is too large.
Any updates on the issue? |
I still don't know what would be the best way to handle this, and whether I should. Any better suggestion? |
I came across this error when I tried bed_autoSVD() function with a very small number of variants (I know that normally several thousand of variants should be used; however, occasionally I have to analyse some awkward datasets). To deal with this error I just explicitly suppress the smoothing log-p-values (as it doesn't make sense in this context) by setting roll.size=0. On my opinion, it might be practically helpful, if you changed the default behaviour to something similar to what I described above. E.g. change Error to Warning, so the function completes, but warns the user that the smoothing had been suppressed. |
Yes, we could default back to 0, or to the largest allowed value, or just implement a version that works even if the size is too large. |
E.g.
bigutilsr::rollmean(x = 1:3, size = 2)
.It expects that
(2 * size + 1) > length(x)
.What strategy to adopt when it is not the case? (+ recode)
The text was updated successfully, but these errors were encountered: