Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

furnace: Instrument makepkg builder #17

Merged
merged 2 commits into from
Jan 29, 2021
Merged

furnace: Instrument makepkg builder #17

merged 2 commits into from
Jan 29, 2021

Conversation

onprem
Copy link
Owner

@onprem onprem commented Jan 26, 2021

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Instrument the Furnace package builder. The exposed metrics are
    • foundry_furnace_builder_builds_started_total: Total number of attempted builds by the builder.
    • foundry_furnace_builder_builds_completed_total: Total number of builds completed by the builder irrespective of success or failure.
    • foundry_furnace_builder_build_failures_total: Total number of builds attempted by the builder that failed.
    • foundry_furnace_builder_build_duration_seconds: Duration of builds completed successfully by the builder. This is a histogram.

Fixes #14

Verification

Added unit test for instrumentedBuilder.

@coveralls
Copy link

coveralls commented Jan 26, 2021

Coverage Status

coverage: 62.733% (+11.9%) from 50.82%
when pulling 71c3ca4 on feat/metrics
into 21a5371 on main.

@onprem onprem merged commit dfcae69 into main Jan 29, 2021
@onprem onprem deleted the feat/metrics branch January 29, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Furnace enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instrumentation
2 participants