Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Focal Length #54

Closed
1 of 2 tasks
chris-traxler opened this issue May 4, 2021 · 5 comments
Closed
1 of 2 tasks

Adjust Focal Length #54

chris-traxler opened this issue May 4, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@chris-traxler
Copy link
Collaborator

chris-traxler commented May 4, 2021

The focal length of the render camera should be adjustable in the GUI. This should work in the same way as for the instrument camera in the View Planner. Task separation:

  • Numerical field in GUI in the range of 28-100mm.
  • Fix the horizontal field of view in the render window (Martin Brunnhuber has solved this for the Dibit-Viewer).
@chris-traxler chris-traxler added the enhancement New feature or request label May 4, 2021
@chris-traxler chris-traxler mentioned this issue May 4, 2021
8 tasks
@LauraFritz14
Copy link
Collaborator

Branch: develop/features/mastcamZ1
Commit c83f4ea

focalGui

@chris-traxler
Copy link
Collaborator Author

Changing the focal length works smoothly. There is just one small usability issue: When activating "useFocal" immediately after PRo3D was launched, it has no effect on the render window. The slider has to be moved first or the input field edited to see an effect.

@LauraFritz14
Copy link
Collaborator

LauraFritz14 commented May 19, 2021

Commit 7761d6e
init focal view with frustum using init focal length to solve the problem described by @chris-traxler

@chris-traxler
Copy link
Collaborator Author

Usability issue described above is fixed with commit 7761d6e.

@LauraFritz14 LauraFritz14 mentioned this issue May 20, 2021
12 tasks
@gpaar gpaar closed this as completed Feb 28, 2023
@gpaar
Copy link
Collaborator

gpaar commented Feb 28, 2023

Redundant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants