Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hcluster -> scipy? #19

Closed
mszep opened this issue Jun 14, 2014 · 3 comments
Closed

hcluster -> scipy? #19

mszep opened this issue Jun 14, 2014 · 3 comments

Comments

@mszep
Copy link

mszep commented Jun 14, 2014

I ran into some problems during the install of crosscat where it tries to install the hcluster package (see my comment on closed issue #8). I looked into why a simple pip install hcluster wouldn't work, and found that hcluster has been incorporated into scipy.

Specifically, these are the hcluster functions that I can see used in crosscat, and their scipy counterparts:

hcluster scipy
pdist spatial.distance.pdist
linkage cluster.hierarchy.linkage
dendrogram cluster.hierarchy.dendrogram

Note that I haven't compared them in detail, but I presume they haven't changed much, if at all; their docstrings look very similar.

It seems that a niggly dependency could be eliminated by switching to the scipy versions, so I'm wondering whether you'd accept pull requests implementing that (if so, are there any tests I should run), or have you considered all this and is there a good reason for using the original hcluster versions?

@jbaxter
Copy link
Contributor

jbaxter commented Jun 14, 2014

Hi @mszep,

Thanks! Yes, a few people been running into trouble installing hcluster, so I agree with you that we should just switch to scipy. I just did it in this commit here: b36cc04

@jbaxter jbaxter closed this as completed Jun 14, 2014
@mszep
Copy link
Author

mszep commented Jun 14, 2014

👍

Although I guess the install scripts should be changed as well, to skip the installing of hcluster?

@jbaxter jbaxter reopened this Jun 14, 2014
@jbaxter
Copy link
Contributor

jbaxter commented Jun 14, 2014

Good catch, thank you. Removed from the scripts here: 5c62662

@jbaxter jbaxter closed this as completed Jun 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants