Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continuous component model can't handle constant column #85

Open
riastradh-probcomp opened this issue Mar 14, 2016 · 1 comment
Open

Comments

@riastradh-probcomp
Copy link
Contributor

This causes construct_continuous_specific_hyper_grid to compute 0 for the sum of squared deviations from the mean, and then to fill s_grid with the smallest positive normal floating-point number, due to a workaround I put into log_linspace a while ago to avoid zeros (which probably had the effect of masking this problem, unbeknownst to ignorant me back then).

The consequences manifest as NaN for marginal logps / logscores when analysis is attempted later. Of course, Crosscat can't conclude anything useful about the column if all its values are the same. But that's no reason for it to barf and choke.

We who are still paying attention to Crosscat ought to sit down and figure out what this hyperparameter gridding business is supposed to accomplish and accomplish it in a way that does not cause mysterious crashes later on.

@gregory-marton
Copy link
Contributor

Such columns are guessed as 'ignore', fwiw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants