Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests leak goroutines because of go-libp2p and leveldb #34

Open
iand opened this issue Oct 2, 2023 · 0 comments
Open

Tests leak goroutines because of go-libp2p and leveldb #34

iand opened this issue Oct 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@iand
Copy link
Contributor

iand commented Oct 2, 2023

Migrated from libp2p/go-libp2p-kad-dht#906

We observed that the 32-bit test runner runs out of memory if we increase the test count to 100.

There are two areas where we leak goroutines after the test has stopped:

  1. leveldb has a one-second delay before properly releasing all resources. There is nothing immediate we can do about that. If we added a delay of 1s + δ, all resources are released.
  2. go-libp2p does not clean up fx resources properly. This is a known issue and will be fixed soon: libp2p.Host leaks goroutines libp2p/go-libp2p#2514

Revisit after libp2p/go-libp2p#2514 has been resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
DHT Optimization
Status: Planned
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iand