Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Make the RegisterDataType enum public #1713

Open
spcan opened this issue Aug 8, 2023 · 1 comment · May be fixed by #2321
Open

[Request] Make the RegisterDataType enum public #1713

spcan opened this issue Aug 8, 2023 · 1 comment · May be fixed by #2321
Labels
enhancement New feature or request

Comments

@spcan
Copy link

spcan commented Aug 8, 2023

Is your feature request related to a problem? Please describe.

I'm trying to use probe_rs as a dependency and the enum probe_rs::core::RegisterDataType is not publicly available, which I need in order to properly format a register's data once it is read.

Describe the solution you'd like

There are two easy solutions
· Make the core module public (in lib.rs change to pub mod core in line 75)
· Make the enum public (in lib.rs add RegisterDataType to the import in lines 93-97)

Describe alternatives you've considered

No available alternatives except by using non generic enums in my app that simply reimplement the same functionality of this enum already.

Additional context

None

@spcan spcan added the enhancement New feature or request label Aug 8, 2023
@noppej
Copy link
Contributor

noppej commented Aug 8, 2023

The second option seems reasonable. Are you willing to PR it?

spcan added a commit to spcan/probe-rs that referenced this issue Sep 6, 2023
Makes `RegisterDataType` public as described in  probe-rs#1713
@bugadani bugadani linked a pull request Mar 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants