Debugger: Add SVD Peripherals and prep for multi-core #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TODO to prevent set variable for SVD Remove TODO tag for progress update in SVD
This was referenced Apr 7, 2022
burrbull
reviewed
Apr 8, 2022
burrbull
reviewed
Apr 8, 2022
|
@Yatekii I snuck in one more commit. My primary motivation is that it is a small change and by including it now, we can avoid having the extra overhead of an extra pair of vscode synchronized PR's later. |
Yatekii
reviewed
Apr 14, 2022
Co-authored-by: Yatekii <Yatekii@users.noreply.github.com>
Yatekii
reviewed
Apr 14, 2022
Yatekii
reviewed
Apr 14, 2022
Yatekii
reviewed
Apr 14, 2022
Yatekii
reviewed
Apr 14, 2022
Yatekii
reviewed
Apr 14, 2022
Yatekii
reviewed
Apr 14, 2022
Yatekii
reviewed
Apr 14, 2022
Yatekii
reviewed
Apr 14, 2022
There was a problem hiding this comment.
Nice that this is finally coming! I love it!
I also like that the debugger.rs finally became a lot smaller and parts were moved out in different files.
Sadly some other huge files kept growing. We should def. see that those do not grow so big :) Should be addressed in other PRs tho.
I added some comments here and there :)
Yatekii
approved these changes
Apr 18, 2022
bors bot
added a commit
to probe-rs/vscode
that referenced
this pull request
Apr 18, 2022
31: Debugger: Add SVD Peripherals and prep for multi-core r=Yatekii a=noppej This PR is part of a trio of PR's that depend on each other: - [Debugger in probe-rs](probe-rs/probe-rs#1072) - Part I of preparing for multi-core support. This will require future PR's to complete. - Restructured source files - large files broken up into smaller units. - Support for loading CMSIS-SVD files and making peripheral values available to the VSCode extension. - [VSCode extension](#31) - A draft version of the extension [probe-rs-debugger-0.4.0.vsix](https://github.com/probe-rs/vscode/releases/tag/v0.4.0) is available to facilitate testing of these PR's. - Changes to `launch.json` configuration to support SVD Peripheral files and core specific configuration. - Updated various development dependencies. - Updated the Debug Adapter Protocol to version 1.55.1. - [Documentation on probe.rs](probe-rs/webpage#47) - Document changes to VSCode `launch.json`. - GIF to demonstrate how to navigate and monitor SVD Peripheral register values. Co-authored-by: JackN <noppej@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a trio of PR's that depend on each other:
launch.jsonconfiguration to support SVD Peripheral files and core specific configuration.launch.json.Note to reviewers: This PR started as simply adding SVD support. Then I realized it doesn't make sense to add all that functionality while disregarding that this is a core-specific capability. As a result I started adding essential logic to configure and handle core-specific settings. Then I realized that the source files were growing out of proportion, so I split them into smaller units. The result is this rather larger PR - I hope the new capability and cleaner source structure makes up for the pain of reviewing such a large PR.