Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Add SVD Peripherals and prep for multi-core #47

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

noppej
Copy link
Contributor

@noppej noppej commented Apr 7, 2022

This PR is part of a trio of PR's that depend on each other:

  • Debugger in probe-rs
    • Part I of preparing for multi-core support. This will require future PR's to complete.
    • Restructured source files - large files broken up into smaller units.
    • Support for loading CMSIS-SVD files and making peripheral values available to the VSCode extension.
  • VSCode extension
    • A draft version of the extension probe-rs-debugger-0.4.0.vsix is available to facilitate testing of these PR's.
    • Changes to launch.json configuration to support SVD Peripheral files and core specific configuration.
    • Updated various development dependencies.
    • Updated the Debug Adapter Protocol to version 1.55.1.
  • Documentation on probe.rs
    • Document changes to VSCode launch.json.
    • GIF to demonstrate how to navigate and monitor SVD Peripheral register values.

@noppej noppej changed the title SVD Viewer in VSCode and Debugger Debugger: Add SVD Peripherals and prep for multi-core Apr 7, 2022
@noppej noppej marked this pull request as ready for review April 7, 2022 19:06
@noppej noppej requested a review from Yatekii April 8, 2022 16:25
bors bot added a commit to probe-rs/probe-rs that referenced this pull request Apr 18, 2022
1072: Debugger: Add SVD Peripherals and prep for multi-core r=Yatekii a=noppej

This PR is part of a trio of PR's that depend on each other:
- [Debugger in probe-rs](#1072)
  - Part I of preparing for multi-core support. This will require future PR's to complete.
  - Restructured source files - large files broken up into smaller units.
  - Support for loading CMSIS-SVD files and making peripheral values available to the VSCode extension.
- [VSCode extension](probe-rs/vscode#31)
  -  A draft version of the extension [probe-rs-debugger-0.4.0.vsix](https://github.com/probe-rs/vscode/releases/tag/v0.4.0) is available to facilitate testing of these PR's.
  -  Changes to `launch.json` configuration to support SVD Peripheral files and core specific configuration.
  - Updated various development dependencies.
  - Updated the Debug Adapter Protocol to version 1.55.1.
- [Documentation on probe.rs](probe-rs/webpage#47)
  -  Document changes to VSCode `launch.json`.
  - GIF to demonstrate how to navigate and monitor SVD Peripheral register values.

Note to reviewers: This PR started as simply adding SVD support. Then I realized it doesn't make sense to add all that functionality while disregarding that this is a core-specific capability. As a result I started adding essential logic to configure and handle core-specific settings. Then I realized that the source files were growing out of proportion, so I split them into smaller units. The result is this rather larger PR - I hope the new capability and cleaner source structure makes up for the pain of reviewing such a large PR.

Co-authored-by: JackN <noppej@hotmail.com>
bors bot added a commit to probe-rs/vscode that referenced this pull request Apr 18, 2022
31: Debugger: Add SVD Peripherals and prep for multi-core r=Yatekii a=noppej

This PR is part of a trio of PR's that depend on each other:
- [Debugger in probe-rs](probe-rs/probe-rs#1072)
  - Part I of preparing for multi-core support. This will require future PR's to complete.
  - Restructured source files - large files broken up into smaller units.
  - Support for loading CMSIS-SVD files and making peripheral values available to the VSCode extension.
- [VSCode extension](#31)
  -  A draft version of the extension [probe-rs-debugger-0.4.0.vsix](https://github.com/probe-rs/vscode/releases/tag/v0.4.0) is available to facilitate testing of these PR's.
  -  Changes to `launch.json` configuration to support SVD Peripheral files and core specific configuration.
  - Updated various development dependencies.
  - Updated the Debug Adapter Protocol to version 1.55.1.
- [Documentation on probe.rs](probe-rs/webpage#47)
  -  Document changes to VSCode `launch.json`.
  - GIF to demonstrate how to navigate and monitor SVD Peripheral register values.

Co-authored-by: JackN <noppej@hotmail.com>
Copy link
Member

@Yatekii Yatekii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 18, 2022

Configuration problem:
bors.toml: not found

@Yatekii Yatekii merged commit dcc6a3f into master Apr 18, 2022
@noppej noppej deleted the vscode_updates branch October 20, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants