-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger: Add SVD Peripherals and prep for multi-core #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2022
noppej
changed the title
SVD Viewer in VSCode and Debugger
Debugger: Add SVD Peripherals and prep for multi-core
Apr 7, 2022
bors bot
added a commit
to probe-rs/probe-rs
that referenced
this pull request
Apr 18, 2022
1072: Debugger: Add SVD Peripherals and prep for multi-core r=Yatekii a=noppej This PR is part of a trio of PR's that depend on each other: - [Debugger in probe-rs](#1072) - Part I of preparing for multi-core support. This will require future PR's to complete. - Restructured source files - large files broken up into smaller units. - Support for loading CMSIS-SVD files and making peripheral values available to the VSCode extension. - [VSCode extension](probe-rs/vscode#31) - A draft version of the extension [probe-rs-debugger-0.4.0.vsix](https://github.com/probe-rs/vscode/releases/tag/v0.4.0) is available to facilitate testing of these PR's. - Changes to `launch.json` configuration to support SVD Peripheral files and core specific configuration. - Updated various development dependencies. - Updated the Debug Adapter Protocol to version 1.55.1. - [Documentation on probe.rs](probe-rs/webpage#47) - Document changes to VSCode `launch.json`. - GIF to demonstrate how to navigate and monitor SVD Peripheral register values. Note to reviewers: This PR started as simply adding SVD support. Then I realized it doesn't make sense to add all that functionality while disregarding that this is a core-specific capability. As a result I started adding essential logic to configure and handle core-specific settings. Then I realized that the source files were growing out of proportion, so I split them into smaller units. The result is this rather larger PR - I hope the new capability and cleaner source structure makes up for the pain of reviewing such a large PR. Co-authored-by: JackN <noppej@hotmail.com>
bors bot
added a commit
to probe-rs/vscode
that referenced
this pull request
Apr 18, 2022
31: Debugger: Add SVD Peripherals and prep for multi-core r=Yatekii a=noppej This PR is part of a trio of PR's that depend on each other: - [Debugger in probe-rs](probe-rs/probe-rs#1072) - Part I of preparing for multi-core support. This will require future PR's to complete. - Restructured source files - large files broken up into smaller units. - Support for loading CMSIS-SVD files and making peripheral values available to the VSCode extension. - [VSCode extension](#31) - A draft version of the extension [probe-rs-debugger-0.4.0.vsix](https://github.com/probe-rs/vscode/releases/tag/v0.4.0) is available to facilitate testing of these PR's. - Changes to `launch.json` configuration to support SVD Peripheral files and core specific configuration. - Updated various development dependencies. - Updated the Debug Adapter Protocol to version 1.55.1. - [Documentation on probe.rs](probe-rs/webpage#47) - Document changes to VSCode `launch.json`. - GIF to demonstrate how to navigate and monitor SVD Peripheral register values. Co-authored-by: JackN <noppej@hotmail.com>
Yatekii
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Configuration problem: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a trio of PR's that depend on each other:
launch.json
configuration to support SVD Peripheral files and core specific configuration.launch.json
.