Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create binary_fa_demo.py #445

Merged
merged 5 commits into from
May 12, 2021
Merged

Create binary_fa_demo.py #445

merged 5 commits into from
May 12, 2021

Conversation

karalleyna
Copy link
Collaborator

@karalleyna karalleyna commented Apr 28, 2021 •
edited

Closes #231

I have attained Figure 20.14 in the book. Could you please review it? @murphyk @mjsML

Figures

1
2
3
4

Possible Issues

  • I want to be consistent with the original code as much as possible. So, I can refactor it if it is needed.

murphyk
murphyk requested changes Apr 30, 2021
View reviewed changes
Copy link
Member

@murphyk murphyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you forgot to add the sigmoid_times_gauss function

@karalleyna
Copy link
Collaborator Author

Thank you @murphyk. I added sigmoid_times_gauss function.

@karalleyna karalleyna requested a review from murphyk April 30, 2021 21:08
murphyk
murphyk requested changes May 4, 2021
View reviewed changes
Copy link
Member

@murphyk murphyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you replace the for-loop in sigmoid-times-gauss wth jax.vmap :)

@karalleyna karalleyna requested a review from murphyk May 12, 2021 01:11
@murphyk
Copy link
Member

murphyk commented May 12, 2021

LGTM, thanks!

@murphyk murphyk merged commit be2345b into probml:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murphyk murphyk Awaiting requested review from murphyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert binaryFaDemoTipping to python
2 participants
@karalleyna @murphyk