Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert binaryFaDemoTipping to python #231

Closed
mjsML opened this issue Mar 11, 2021 · 12 comments · Fixed by #445
Closed

Convert binaryFaDemoTipping to python #231

mjsML opened this issue Mar 11, 2021 · 12 comments · Fixed by #445
Assignees

Comments

@mjsML
Copy link
Member

mjsML commented Mar 11, 2021

This is figure number 20.14 in the book. its matlab code is here

@Raghibshams456
Copy link

@mjsML please assign to me I am interested to do this...

@Raghibshams456
Copy link

@mjsML there are some functions that are used in this code as printPmtkFigure('binaryPCAhidden') and muPost = binaryFAinferLatent(model, dataNoisy) are they should be also converted in python/jax??

@Raghibshams456
Copy link

@mjsML I am not able to understand binaryFafit() function ..can you please explain..I am converting using jax and python but got stuck in this function..

@mjsML
Copy link
Member Author

mjsML commented Mar 26, 2021

You can search the pmtk3 repo and you would find the source for binaryFafit here , I believe the scikit-learn module you would look at is this.

@Raghibshams456
Copy link

@mjsML @nappaillav I have done almost same with jax as told instead numpy should I open pr ?? I have taken help from @nappaillav code for one function of latent embedding...

@nappaillav
Copy link
Contributor

@Raghibshams456 if you feel some part of my code needs correction let me know, we can correct it.
And we can complete the PR together. Does that sound fine?

@Raghibshams456
Copy link

Raghibshams456 commented Mar 29, 2021

@nappaillav nothing is wrong with ur code...I done this in jax instead numpy...I have created pr please have a look I was struggling in one function

@nappaillav
Copy link
Contributor

@Raghibshams456 I'm not a PR reviewer yet.
As per my knowledge we are converting matlab code to python, JAX is not required, but it will be use full in future.
Hence, I would not want your efforts go wasted, So I will add you as the collaborator to my contribution, and If there are changes requested we can complete it.
:)

@Raghibshams456
Copy link

ok

@karalleyna
Copy link
Collaborator

karalleyna commented Apr 23, 2021

I'm working on this if it is okay for you.

@mjsML
Copy link
Member Author

mjsML commented Apr 23, 2021

I'm working on this if it is okay for you.

Please go ahead.
However, be mindful of the previous attempt to do this #322 , the fact that this is an advanced level issue and specially @murphyk comment.

@mjsML
Copy link
Member Author

mjsML commented Apr 25, 2021

Temporarily closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants