Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance.ini format #558

Closed
probonopd opened this issue Nov 12, 2023 · 3 comments
Closed

Improve performance.ini format #558

probonopd opened this issue Nov 12, 2023 · 3 comments

Comments

@probonopd
Copy link
Owner

We should improve https://github.com/probonopd/MiniDexed/blob/main/src/performanceconfig.h/.cpp so that we can use something like

; Tone Generator 1
[TG1]
Key=Value

; Tone Generator 2
[TG2]
Key=Value

Maybe we need to investigate something like https://github.com/pulzed/mINI to read and write a more complete .ini format?

@probonopd
Copy link
Owner Author

Looks like the infrastructure for this might land in Circle sooner or later.

@diyelectromusic
Copy link
Contributor

I'm not really sure what the complexity offers over the existing format. Once preset performances are defined, most people would only be saving them from the UI, so won't really benefit from a more user-readable format anyway?

If we did anything (and I'm not convinced we should tbh) then moving to a binary sysex format (as described here: #533) probably makes more sense, especially if tools will be required to read/write the new files...?

And if we're writing tools, then a converter from a format like the above to the existing format probably is a lot easier than adding support directly in MiniDexed (even if added to circle)?

Kevin

@probonopd
Copy link
Owner Author

I'm not really sure what the complexity offers over the existing format

Would have made it easier (a bit) to read and write by hand.

But possibly not worth the effort, especially now that tools and performances already exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants