Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Denon receiver directories? #14

Closed
lbschenkel opened this issue Aug 2, 2018 · 4 comments
Closed

Unify Denon receiver directories? #14

lbschenkel opened this issue Aug 2, 2018 · 4 comments

Comments

@lbschenkel
Copy link
Contributor

lbschenkel commented Aug 2, 2018

Hi, is there any reason for why the Denon directory has separate sub-directories for "AV Receiver", "Receiver" and "Surround Receiver"? What's the reasoning behind this distinction? Unless I missed something, they all implement the same commands and having this distinction brings confusion since you have to remember to look into these 3 different places because the files in some directories are more complete than others.

The reason I'm asking is because I would like to contribute some missing codes, but before doing that I can volunteer to do the work to unify/de-duplicate all the files in these different directories under a single Receiver directory.

@probonopd
Copy link
Owner

Not really... I don't know every device (type) myself. if you think we should unify the categories, let's do it. Let's just use "Receiver". PR welcome.

@lbschenkel
Copy link
Contributor Author

OK, great. I already started the work. Will submit a PR in the upcoming days.

@lbschenkel
Copy link
Contributor Author

Closing this, since #15 was submitted and merged.

@probonopd
Copy link
Owner

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants