feat: v13 #1874

wolfy1339 · 2023-10-29T01:55:09Z

BREAKING CHANGE: Drop support for NodeJS < 18
BREAKING CHANGE: replace node-fetch with the Fetch API
BREAKING CHANGE: default webhookPath is now /api/github/webhooks
BREAKING CHANGE: probot receive now only supports payloads in JSON format, previously also (unintionally) allowed JS.

closes #1643

BREAKING CHANGE: Drop support for NodeJS < 18 BREAKING CHANGE: replace `node-fetch` with the Fetch API

src/octokit/get-probot-octokit-with-defaults.ts

.github/workflows/test.yml

fix linting of extensions.md

Remove @tsconfig/node10 from devDepedencies as we are streamling with @octokit/tsconfig

src/octokit/get-authenticated-octokit.ts

chore: remove semver as dependency

* Set up code scanning This sets up CodeQL to automatically detect possible security problems. * Add more queries

test/probot-octokit.test.ts

…#1887) chore: simplify auth.ts

…ot-receive (#1891)

…able (#1881)

…endencies (#1897)

This updates all dependencies and replaces jest with vitest. Co-authored-by: wolfy1339 <webmaster@wolfy1339.com> Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com> Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com> Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>

AaronDewes · 2023-11-14T09:02:07Z

What I'd like to do before merge (Am I missing anything here?):

chore: Clean up code in beta branch #1900 (code suggestions by @wolfy1339)
chore(deps): update dependency @types/node to v20 #1875 (Or should we keep v18 @types/node)?
Document breaking changes in v13/migration guide

After the release:

chore: Make example on front page ESM probot.github.io#527

Since Node 18, Headers is a global.

gr2m · 2023-12-06T00:03:39Z

Huh, we should probably put this into Octokit 🤔 unless it has bad performance implications, but I'd only happen in the constructor so I don't think so? I don't mind leaving this in Probot to avoid the breaking change

Uzlopak · 2023-12-06T00:13:30Z

I dont have any clue, why the aliasLog was removed in the first place. Or why its type was called "DeprecatedLogger". I assume that there are some deeper thoughts behind that. Would be glad if you or @wolfy1339 could take care of it, because it is 1 a.m. in the morning and i have to grab some sleep. :D

wolfy1339 · 2023-12-06T01:08:46Z

4e7884e

This is the source of the type DeprecatedLogger

This commit deprecated .logging in favor of .log
2bacd14

So it seems that the name is lingering from old times, and the aliasLog function is remnant from the revert of the depreciation, but the name wasn't updated

Fix typo in simulating-webhooks.md

gr2m · 2024-01-14T19:05:22Z

Hey shall we ship v13? Anything that is left to do from your perspective?

wolfy1339 · 2024-01-14T19:11:24Z

There is the log binding issue that should be addressed.

Other than that, nothing seems to be blocking the release

Uzlopak · 2024-01-16T06:21:58Z

I could not reproduce the log binding error in a test. So it was not clear if the problem would be solved with that PR.
I would say, lets merge and release it as v13.
People will report if this log binding issue was not only a fluke.
Or we decide to merge the log binding PR, which u closed rn, but without a test...

AaronDewes · 2024-01-16T20:21:43Z

I dont have any clue, why the aliasLog was removed in the first place. Or why its type was called "DeprecatedLogger". I assume that there are some deeper thoughts behind that. Would be glad if you or @wolfy1339 could take care of it, because it is 1 a.m. in the morning and i have to grab some sleep. :D

I think I did that and removed it because it was called DeprecatedLogger, so I just thought it was a backwards-compat thing and was supposed to be removed in a major release.

Uzlopak · 2024-01-16T21:37:39Z

So should we merge #1939 just for the sake of it?

Uzlopak · 2024-01-18T03:01:00Z

I merged it. Maybe we can finally release :D

AaronDewes

LGTM, let's go 🚀

Uzlopak

LGTM!

gr2m

@wolfy1339 all yours!

github-actions · 2024-01-25T21:04:08Z

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This is necessary with probot@13, see probot/probot#1874 (comment).

nikku · 2024-01-31T23:58:50Z

This is a breaking change and hit my during my probot app update. General search was not helpful, so the only way to find it was to skim through all conversations to find that comment.

Uzlopak · 2024-02-01T00:05:32Z

@nikku
We tried to mitigate the issue via #1939 but it seems we were not successful. If you have an idea on why this happens, we are glad to accept a PR from you. I dont have a clue, why this happens or how we can fix it.

gr2m · 2024-02-09T23:58:02Z

I finally updated the WIP app to probot v13, thanks to nock@beta which now supports native fetch mocking 🎉 which blocked me. One thing I observed is that tests now take forever, as if the way I disabled throttling no longer works. Did anyone else observe something similar? I didn't have time to dig deeper into it:
wip/app#631

UPDATE: had a quick look, throttling definitely remains enabled although I disable it e.g. here:
https://github.com/wip/app/blob/70b9da8a45ee39be4c107692f6fadd90b1bacad5/test/integration/pro-plan-test.js#L34

Not sure why yet, might be a ProbotOctokit or even an Octokit bug with how defaults are set

travi · 2024-02-10T02:43:49Z

Did anyone else observe something similar?

there is an open report here: #1972

feat: make probot work with latest octokit deps (#1864)

a6f4474

BREAKING CHANGE: Drop support for NodeJS < 18 BREAKING CHANGE: replace `node-fetch` with the Fetch API

wolfy1339 added the breaking change label Oct 29, 2023

shaftoe and others added 3 commits October 29, 2023 02:06

fix(docs): remove NodeJS v10 references (#1670)

5f75d18

chore(deps): update dependency semantic-release to v22 (#1857)

e5e324d

chore(deps): update dependency prettier to v3 (#1854)

63d5ee7

wolfy1339 marked this pull request as ready for review October 29, 2023 02:56

wolfy1339 requested a review from a team as a code owner October 29, 2023 02:56

AaronDewes reviewed Oct 29, 2023

View reviewed changes

src/octokit/get-probot-octokit-with-defaults.ts Outdated Show resolved Hide resolved

Uzlopak reviewed Nov 9, 2023

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

style:prettier (#1877)

2545a45

fix linting of extensions.md

This comment was marked as outdated.

Sign in to view

build(deps-dev): remove @tsconfig/node10 (#1884)

4d031c1

Remove @tsconfig/node10 from devDepedencies as we are streamling with @octokit/tsconfig

wolfy1339 commented Nov 10, 2023

View reviewed changes

src/octokit/get-authenticated-octokit.ts Outdated Show resolved Hide resolved

src/octokit/get-authenticated-octokit.ts Outdated Show resolved Hide resolved

Uzlopak and others added 2 commits November 12, 2023 09:50

fix(deps): -semver (#1893)

0251f68

chore: remove semver as dependency

ci(security): Set up code scanning (#1882)

4100b25

* Set up code scanning This sets up CodeQL to automatically detect possible security problems. * Add more queries

github-advanced-security bot found potential problems Nov 12, 2023

View reviewed changes

test/probot-octokit.test.ts Fixed Show resolved Hide resolved

test/probot-octokit.test.ts Fixed Show fixed Hide fixed

test/probot-octokit.test.ts Fixed Show fixed Hide fixed

Uzlopak and others added 10 commits November 12, 2023 10:09

refactor: remove log argument from auth.ts to improve test coverage (…

4699a3c

…#1887) chore: simplify auth.ts

fix: use import() instead of require to import smee-client (#1889)

8999768

chore: avoid require to load package.json (#1890)

3694baf

refactor: avoid require for dotenv.config() (#1894)

c2b7cb9

fix: correctly escape . in URL regex (#1895)

8dde11e

chore(ci): add node21 to ci/cd workflow (#1896)

c0fb103

fix: use readFileSync and JSON.parse instead of require in prob…

3219a98

…ot-receive (#1891)

fix: determine webhook path for createNodeMiddleware() via env vari…

753c71b

…able (#1881)

chore(ci): add dependency review and license check for production dep…

9a9079d

…endencies (#1897)

chore: remove undici (#1902)

c30d88f

Since Node 18, Headers is a global.

wolfy1339 mentioned this pull request Dec 19, 2023

Disable Request Logging #1940

Open

docs: formatting typo in simulating-webhooks.md (#1942)

5e302ce

Fix typo in simulating-webhooks.md

nitrocode mentioned this pull request Jan 9, 2024

[BUG]: Upgrade universal-github-app-jwt 1.1.2 to close CVE-2022-25883 octokit/auth-app.js#561

Closed

1 task

fix: bind log (#1939)

e25f1ae

AaronDewes approved these changes Jan 18, 2024

View reviewed changes

Uzlopak approved these changes Jan 18, 2024

View reviewed changes

AaronDewes requested a review from gr2m January 18, 2024 08:05

PurpleMaster1 mentioned this pull request Jan 24, 2024

See https://github.com/probot/probot/pull/1874 PurpleMaster1/git-remote1#1

Closed

gr2m approved these changes Jan 25, 2024

View reviewed changes

wolfy1339 merged commit 948a1b7 into master Jan 25, 2024
21 checks passed

wolfy1339 deleted the beta branch January 25, 2024 21:03

github-actions bot added the released label Jan 25, 2024

nikku added a commit to nikku/wuffle that referenced this pull request Jan 31, 2024

fix(app): pre-bind log

d71a0a8

This is necessary with probot@13, see probot/probot#1874 (comment).

nikku added a commit to nikku/wuffle that referenced this pull request Jan 31, 2024

fix(app): pre-bind log

c19e77a

This is necessary with probot@13, see probot/probot#1874 (comment).

gr2m mentioned this pull request Feb 10, 2024

Testing probot app significantly slower in v13 #1972

Open

unfurl-links bot mentioned this pull request Mar 12, 2024

The log level isn't adjustable and every hook reaction is returning POST 404 #1987

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: v13 #1874

feat: v13 #1874

wolfy1339 commented Oct 29, 2023 •

edited by gr2m

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

AaronDewes commented Nov 14, 2023 •

edited

gr2m commented Dec 6, 2023

Uzlopak commented Dec 6, 2023

wolfy1339 commented Dec 6, 2023

gr2m commented Jan 14, 2024

wolfy1339 commented Jan 14, 2024

Uzlopak commented Jan 16, 2024

AaronDewes commented Jan 16, 2024

Uzlopak commented Jan 16, 2024

Uzlopak commented Jan 18, 2024

AaronDewes left a comment

Uzlopak left a comment

gr2m left a comment

github-actions bot commented Jan 25, 2024

nikku commented Jan 31, 2024

Uzlopak commented Feb 1, 2024

gr2m commented Feb 9, 2024 •

edited

travi commented Feb 10, 2024

feat: v13 #1874

feat: v13 #1874

Conversation

wolfy1339 commented Oct 29, 2023 • edited by gr2m

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

AaronDewes commented Nov 14, 2023 • edited

gr2m commented Dec 6, 2023

Uzlopak commented Dec 6, 2023

wolfy1339 commented Dec 6, 2023

gr2m commented Jan 14, 2024

wolfy1339 commented Jan 14, 2024

Uzlopak commented Jan 16, 2024

AaronDewes commented Jan 16, 2024

Uzlopak commented Jan 16, 2024

Uzlopak commented Jan 18, 2024

AaronDewes left a comment

Choose a reason for hiding this comment

Uzlopak left a comment

Choose a reason for hiding this comment

gr2m left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 25, 2024

nikku commented Jan 31, 2024

Uzlopak commented Feb 1, 2024

gr2m commented Feb 9, 2024 • edited

travi commented Feb 10, 2024

wolfy1339 commented Oct 29, 2023 •

edited by gr2m

AaronDewes commented Nov 14, 2023 •

edited

gr2m commented Feb 9, 2024 •

edited