Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Configurable sweep period #12

Closed
rafaelfranca opened this issue Mar 28, 2017 · 2 comments · Fixed by #13
Closed

Configurable sweep period #12

rafaelfranca opened this issue Mar 28, 2017 · 2 comments · Fixed by #13

Comments

@rafaelfranca
Copy link
Contributor

In Rails we mark issues as stale after 90 days and we want to close them if there is no response after one week.

For what I could get in the code seems that the sweep time is equal to the double of the number of days configured to mark as stale, since marking as stale changes the updated_at attribute and now that issue will only be found by the getIssues() function after the updated_at is greater than 90 days.

Should we have different schedules for mark and sweep phases?

@bkeepers
Copy link
Contributor

👍 I was thinking the same after talking with @lee-dohm about using this on @atom.

What should the configs be called? daysUntilStale and daysUntilClose?

@rafaelfranca
Copy link
Contributor Author

Those name are good to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants