Pull request stale search don' t get any of the stale PRs

[rafaelfranca]

Debugging the search that is being made I saw that a search for open PRs that are not updates in the last three months return an empty result even that the repository have a lot of stale PR as it is the case of activeresource.

https://github.com/rails/activeresource/search?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+updated%3A%3C2017-02-04T22%3A51%3A53&type=Issues

https://github.com/rails/activeresource/pulls

Maybe the GitHub search can't be used for that?

[bkeepers]

It looks like all of the open issues in https://github.com/rails/activeresource recently had activity that was later marked as spam, which touched the updated field.

$ curl -s https://api.github.com/repos/rails/activeresource/issues/179 | jq .updated_at
"2017-04-21T18:30:43Z"

If you search for <2017-04-22, all the results are there.

I pointed out the issue with to our spam team to see if they could revert changes to the updated field when marking activity as spammy, but I doubt it will be worth the engineering effort.

Let me know if you see any other examples of the search not working though.

[bkeepers]

Maybe the GitHub search can't be used for that?

Sorry, forgot to acknowledge this. We could definitely rewrite this plugin to not use search, but the only way to get around the spam issue will be to fetch the event timeline for every single issue, which will be a lot of API requests.

I'm not opposed to reviewing a PR that does that, but it's not a priority for me right now.