-
Notifications
You must be signed in to change notification settings - Fork 886
Fix for #237 the print command doesn't open the console #252
Conversation
} else { | ||
e.javaconsole.scrollTop = e.javaconsole.scrollHeight; | ||
} | ||
if (e.BufferArray.length > e.BufferMax) e.BufferArray.splice(0, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't include formatting changes in a functional PR, especially in this case: curly brackets serve a purpose, don't slow down code, and make things easier to read. Removing them is not a good idea =)
Looks good, but remember to focus on the issue at hand: if you're adding a PR that fixes (You can always file a new issue for fixing the formatting issue, and then land a second PR specifically for that) |
Dunno much about print()'s implementation. The actual console.log() always append a linefeed at the end. Which of course doesn't match print()'s expected behavior... |
Note that the |
Alas, censorship again as always... |
I undid the formatting changes. I only did them because the original poster thought it might be good to keep the formatting consistent throughout the file ;-) But thanks for the feedback, I'll keep this in mind for future pull request. |
In my deleted post, I've agreed w/ your 1 liner |
I personally don't mind the curly braces. |
@GoToLoop apologies for that: I'm deleting any comment that sounds mocking, or unrelated to the PR itself (your comment was a joke involving me not likeing python programming style, which has nothing to do with a JS codebase. PR comments are for comments on code, not for comments about the people who wrote the code or review the code) |
Hi,
This should be a fix for issue #237.
In this issue a fix was described already. I simply implemented it.
Now the console becomes visible when using print as well as println. I couldn't think of a way to add tests for it, so there aren't any. If you can think of a way to test this, I'd be willing to try to implement it.
Running node test didn't generate processing.min.js, so it's not included.
processing.js contains some unrelated changes again. I guess it might be because some files were changed after processing.js was updated.
Cheers,
Jean-Noël