p5.SoundLoop() #210
Merged
p5.SoundLoop() #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
therewasaguy
reviewed
Aug 9, 2017
examples/sound_loop/sketch.js
Outdated
| console.log('looper1 '+this.clock._nextTick); | ||
| }, 1); | ||
|
|
||
| looper2 = new p5.SoundLoop(function(time){ |
There was a problem hiding this comment.
maybe we should change this to be timeFromNow to be clearer ?
examples/sound_loop/sketch.js
Outdated
|
|
||
| looper2 = new p5.SoundLoop(function(time){ | ||
|
|
||
| beatbox.play(); |
There was a problem hiding this comment.
we should pass timeFromNow in as a parameter
examples/sound_loop/sketch.js
Outdated
| d = color(50); | ||
| // create a part with 8 spaces, where each space represents 1/16th note (default) | ||
| looper1 = new p5.SoundLoop(function(time){ | ||
| click.play(); |
src/soundLoop.js
Outdated
| this.clock = new Clock({ | ||
| 'callback' : function(time) { | ||
| var timeFromNow = time - p5sound.audiocontext.currentTime; | ||
| if (timeFromNow > 0) {self.callback(timeFromNow);} |
There was a problem hiding this comment.
why would this be less than zero anyway? ah, @jvntf and I are testing together and found that this is the case when we load the page. Maybe worth adding a comment?
src/soundLoop.js
Outdated
| p5.SoundLoop.prototype._calcFreq = function() { | ||
| if (typeof this._interval === 'number') { | ||
| this.musicalTimeMode = false; | ||
| return this._bpm / 60 / this._interval * (this._timeSignature / 4); |
There was a problem hiding this comment.
it seems like this should just set the interval in seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A redesigned
p5.Looper---based on discussions with @therewasaguy re: a sort of draw loop for sound.
a simpler version of the
p5.Phrase / p5.Part / p5.Scoreecosystemits just a loop! set an interval for how often a callback should be called.
use numerical notation to specify interval in seconds, or use ToneJS time notation which corresponds to the loopers BPM. Change the interval at any time and it will be reflected in the next iteration of the loop.
TODO: iteration counting / capping, clock syncing of multiple loops, triplets
p5.Looperis based on Tone.Clock rather than Tone.Transport because it is a relatively simple application, and I thought it wouldn't need all the features of Transport. also, to include less code in the library rather than more.