Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify dark theme #1342

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Modify dark theme #1342

merged 2 commits into from
Apr 1, 2020

Conversation

Eswaraprasadp
Copy link
Contributor

@Eswaraprasadp Eswaraprasadp commented Mar 25, 2020 •
edited
Loading

Fixes #1263 partially

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Mar 25, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@catarak
Copy link
Member

catarak commented Apr 1, 2020

Thanks for working on this! I added a few more changes. I don't think the dark theme is 100% there but it's definitely better!

@catarak catarak merged commit 2744ea4 into processing:master Apr 1, 2020
@catarak catarak mentioned this pull request Apr 1, 2020
Closed
@Eswaraprasadp
Copy link
Contributor Author

Thank you @catarak !

@elit-altum elit-altum mentioned this pull request Apr 4, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Theme Colors + Accessibility
2 participants
@Eswaraprasadp @catarak