Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toolbar): centered the toolbar icons #1366

Merged
merged 2 commits into from
Apr 9, 2020
Merged

fix(toolbar): centered the toolbar icons #1366

merged 2 commits into from
Apr 9, 2020

Conversation

elit-altum
Copy link
Contributor

@elit-altum elit-altum commented Apr 6, 2020 •
edited
Loading

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • The icons of the toolbar buttons were misaligned inside their divs. This PR fixes that by centering them.

ScreenShots:

Before
Issue

After
Fixed

Changes
This might help in noticing the changes :
I have toggled the original view and the changed view to help notice the changes.
FIxing-Animation

@elit-altum
Copy link
Contributor Author

@catarak Could you please review ?

Thank You!

@catarak
Copy link
Member

catarak commented Apr 9, 2020 •
edited
Loading

Thank you! I have noticed this and meant to open an issue but keep forgetting to. In the future could you open an issue first? It's helpful for documentation.

@catarak catarak merged commit 65cd912 into processing:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elit-altum @catarak