Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to earlier fixes to address outage logs #3098

Merged
merged 7 commits into from
Apr 26, 2024

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Apr 26, 2024

Progress towards #3096

Changes:

  • Explicitly returns error if no user data is present in serializeUser() in server/config/passport.js
  • Updates to async/await syntax and adds more specified error messaging in server/controllers/aws.controller.js and server/controllers/project.controller/deleteProject.js
  • Updates server/controllers/project.controller/__test__/deleteProject.test.js with changes to deleteProject.js
  • Removes console.error() in ``server/models/user.js`. This scenario happens when a user who signed up via Google or Github attempts to login through email/password. A better way to handle this can be revisited.
  • Creates generic authenticateOauth() function to create route handlers for each login service and adds error handling when no user is present in server/routes/passport.routes.js

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

release-com bot commented Apr 26, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-a70c2d285c

@raclim raclim merged commit 19367cb into release Apr 26, 2024
4 checks passed
@raclim raclim deleted the fix/updates-address-outage branch April 26, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant