Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent folder names for mac binaries #5006

Closed
monkstone opened this issue Apr 15, 2017 · 7 comments
Closed

Inconsistent folder names for mac binaries #5006

monkstone opened this issue Apr 15, 2017 · 7 comments

Comments

@monkstone
Copy link
Contributor

monkstone commented Apr 15, 2017

There is an inconsistency in the naming of the folder containing MacOS binaries, the sound library uses plain macosx, whereas the video library uses macosx64.

@gohai
Copy link
Contributor

gohai commented Apr 15, 2017

That's likely a workaround in the video library, since the external library it depends on (GStreamer) might not have existed in a "universal binary" form (i.e. support for x86 and x64 in the same file).

But the proper library folder for macOS is macosx.

@gohai gohai closed this as completed Apr 15, 2017
@monkstone
Copy link
Contributor Author

@gohai thanks for swift response, but I'm not much wiser, I kind of knew macosx was the proper folder, I'm not sure whether you closed issue, because a fix is in hand or whether my input is unwelcome. I'm in the process of a major refactor of the library loader for JRubyArt and propane (successors to ruby-processing) so the naming is important to me. By the way video library is broken on Archlinux and I'm not quite sure why, if I get the mojo I might take a serious look at it, but may'be that would be unwelcome too?

@gohai
Copy link
Contributor

gohai commented Apr 16, 2017

@monkstone While there are guidelines and recommendations, at the end libraries have quite a bit of autonomy how they go about doing things... for some particular reason, the video library uses macosx64, which is due to this line in its code, and not in Processing (proper). My guess is that this was required to support both x86 and x64, the former of which seem to have been removed since. To this end, this seems to be a valid observation, and thanks for reporting, but just an implementation detail in a library - a core one, but still a library.

If you care about this misnomer, feel free to create an issue in processing-video, or send a PR there as well. But given that the naming alone isn't much of a show-stopper for using the library (as least that's how I understood your submission), and our resources are constrained, I am not sure if this will be acted upon there either. That's why I closed the issue. Hope this clears it up.

@monkstone
Copy link
Contributor Author

@gohai thanks for clarification, my resources are even more restrained (ie so far its only me) so for the moment I won't be doing anything about Archlinux (it is only a minor distro) and Mint (and hence probably other Debian/Ubuntu) still work fine. Problem may due existence of gstreamer-1.0 which is supposed to co-exist with gstreamer-0.10 but may'be not in this case.

@benfry
Copy link
Contributor

benfry commented Apr 21, 2017

Libraries that are 64-bit specific should have the 64 prefix, same for 32-bit libraries. But on macOS, it doesn't really matter either way, because there's no such thing as 32-bit on macOS anymore. So using macosx and macosx64 gives you the same result.

If the sound library is using macosx but doesn't include a 32-bit binary, please file the issue with that repo so that they're aware.

@benfry
Copy link
Contributor

benfry commented Apr 23, 2017

Come to think of it, maybe it's fine as-is. I just need to remove the warning about 32-bit not being available when exporting with the video library.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants