Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing docs and keywords for TableRow. #4333

Merged
merged 2 commits into from Nov 10, 2016

Conversation

suheb
Copy link
Contributor

@suheb suheb commented Feb 27, 2016

Fixes #4332
Signed-off-by: Suhaib Khan suheb.work@gmail.com

Signed-off-by: Suhaib Khan <suheb.work@gmail.com>
@benfry
Copy link
Contributor

benfry commented May 8, 2016

@REAS This is one to be added to your keywords generator (rather than merged into keywords.txt).

@REAS
Copy link
Member

REAS commented May 9, 2016

This is a quick, easy fix, but it's a slippery slope that I worry about. I don't want to make it difficult, but we have many "advanced" methods across many classes that aren't in the simplified reference. Right now, all of the color coding in the PDE comes from this simplified reference list or the hardwired items. If we add these to the hardwired items, there are additional dozens that should be added too. Is that what we want to do? It's making more sense, the more I think about it.

@benfry
Copy link
Contributor

benfry commented May 9, 2016

Yep, agreed. getColumnCount() and getColumnTitle() are the ones to include in the reference, the others all belong in the javadoc.

But a PR that improves the javadoc for the others would be welcome.

@suheb
Copy link
Contributor Author

suheb commented May 12, 2016

@benfry Should I remove these methods from keywords.txt? Also, what the correct place to add keywords then?

@REAS
Copy link
Member

REAS commented May 23, 2016

This is the correct spot: https://github.com/processing/processing-docs/blob/master/generate/keywords_base.txt

The keywords.txt file is generated, it shouldn't be edited directly.

@benfry
Copy link
Contributor

benfry commented Nov 10, 2016

@suheb Would you like to update this to add those two keywords to keywords_base.txt, remove them from keywords.txt and re-submit this patch, or should I close it?

@suheb
Copy link
Contributor Author

suheb commented Nov 10, 2016

@benfry Ohh, sorry about this. I thought I'd fixed this. Will update this PR and open a new one in processing-docs.

@benfry
Copy link
Contributor

benfry commented Nov 10, 2016

Great, thanks!

@suheb
Copy link
Contributor Author

suheb commented Nov 10, 2016

Done. Here's the other PR. Let me know if anything's needed.

@benfry benfry merged commit a2d413c into processing:master Nov 10, 2016
@benfry
Copy link
Contributor

benfry commented Nov 10, 2016

Thanks, I'll let the docs folks handle the other one so that they can run the necessary build scripts.

benfry added a commit that referenced this pull request Nov 10, 2016
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax for TableRow methods aren't recognized by the highlighter
3 participants