New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing docs and keywords for TableRow. #4333
Conversation
Signed-off-by: Suhaib Khan <suheb.work@gmail.com>
@REAS This is one to be added to your keywords generator (rather than merged into |
This is a quick, easy fix, but it's a slippery slope that I worry about. I don't want to make it difficult, but we have many "advanced" methods across many classes that aren't in the simplified reference. Right now, all of the color coding in the PDE comes from this simplified reference list or the hardwired items. If we add these to the hardwired items, there are additional dozens that should be added too. Is that what we want to do? It's making more sense, the more I think about it. |
Yep, agreed. But a PR that improves the javadoc for the others would be welcome. |
@benfry Should I remove these methods from |
This is the correct spot: https://github.com/processing/processing-docs/blob/master/generate/keywords_base.txt The |
@suheb Would you like to update this to add those two keywords to |
@benfry Ohh, sorry about this. I thought I'd fixed this. Will update this PR and open a new one in processing-docs. |
Great, thanks! |
Done. Here's the other PR. Let me know if anything's needed. |
Thanks, I'll let the docs folks handle the other one so that they can run the necessary build scripts. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #4332
Signed-off-by: Suhaib Khan suheb.work@gmail.com