Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle characters with shift modifiers in FX2D (#5317) #5563

Closed
wants to merge 2 commits into from
Closed

Handle characters with shift modifiers in FX2D (#5317) #5563

wants to merge 2 commits into from

Conversation

christianbender
Copy link

@christianbender christianbender commented Jun 28, 2018

I fixed the issue #5317 . And test it with the various modes. (FX2D, P2D, none)

void setup()
{
  size(200,200, FX2D);
  //size(200,200, P2D);
  //size(200,200);
}

void draw()
{
  if (key == '+')
   {
     // println("catch + inside draw"); 
   }
}

void keyPressed()
{
   //println("key pressed! --> " + key);
   if (key == '+')
   {
      println("catch + inside keyPressed"); 
   }
}

Now the println("catch + inside keyPressed"); in the function keyPressed() will correct fired.
Thank @benfry for the help! Without you I had not found the proper place to fix.

NOTE: I added the shift characters * # < > , ! " § $ % & / ( ) = . : ; - _

@gohai gohai changed the title I fixed the issue #5317 Handle characters with shift modifiers in FX2D (#5317) Jun 30, 2018
@gohai
Copy link
Contributor

gohai commented Jun 30, 2018

Thank you @christianbender - I've heard Ben is currently vacationing with family, but he'll sure have a look at your patches for upcoming releases

@christianbender
Copy link
Author

@gohai Thank you for the feedback.

@liquidev
Copy link
Contributor

liquidev commented Jul 24, 2018

Just wanted to note that this is a very poorly done fix, as it detects characters for one specific (German) layout of the keyboard. I (and many people) have a US layout keyboard and the shift-keys are different here.

@benfry
Copy link
Contributor

benfry commented Jul 24, 2018

Nuts, @liquid600pgm is correct. Let's move the discussion over to the original report.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants