Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stacktrace logging by default #276

Closed
Castaglia opened this issue Apr 28, 2016 · 4 comments
Closed

Enable stacktrace logging by default #276

Castaglia opened this issue Apr 28, 2016 · 4 comments
Assignees
Milestone

Comments

@Castaglia
Copy link
Member

Currently, ProFTPD has some support for logging stacktraces in e.g. the face of a SIGSEGV signal -- but only if the --enable-devel=stacktrace compile-time option is used. Those stacktrace logging can be very useful when diagnosing errors, and especially when users report errors. That being the case, why not have stacktrace support enabled by default, rather than disabled by default? There would then be a --disable-stacktrace compile-time option offered, of course.

Note that in order for stacktrace logging to work, the installed binaries must not be stripped. Thus when working on this feature, make sure to adjust the Makefiles' install targets accordingly.

@Castaglia Castaglia self-assigned this Apr 28, 2016
@Castaglia Castaglia modified the milestones: 1.3.7, 1.3.6 Apr 28, 2016
@Castaglia
Copy link
Member Author

There are some other considerations that affect stack traces to be researched: compiler optimization flags, suid restrictions, etc.

@Castaglia
Copy link
Member Author

I'd like to get this enhancement into 1.3.6, in order to support #254 . Specifically, I'd like to include stack traces in the logged errors, when necessary. See also this pull request.

@Castaglia
Copy link
Member Author

From the glibc manual on backtraces, it looks like we'll need to add the -rdynamic linker flag, at the very least.

@Castaglia
Copy link
Member Author

Fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant