Add client commands #767
Merged
Add client commands #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds: - `CLIENT SETNAME` - `CLIENT GETNAME` - `CLIENT ID`
gvolpe
requested changes
Jan 7, 2023
gvolpe
reviewed
Jan 7, 2023
modules/tests/src/test/scala/dev/profunktor/redis4cats/TestScenarios.scala
Outdated
Show resolved
Hide resolved
alfabetacain
force-pushed
the
feat/add-client-commands
branch
from
6fb881f
to
1775717
Compare
auto-merge was automatically disabled
January 7, 2023 18:12
Head branch was pushed to by a user without write access
|
The docs didn't compile, but it should be fixed now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
CLIENT SETNAMECLIENT GETNAMECLIENT IDI'm not really sure how to test
CLIENT ID. According to the redis docs (https://redis.io/commands/client-id/), it seems that it is just an arbitrary (if increasing) long. So the current test just exercises the method.