Skip to content
This repository has been archived by the owner on May 2, 2019. It is now read-only.

[it] Improvement of translation of the second chapter #235

Closed
wants to merge 7 commits into from

Conversation

DavidePastore
Copy link
Contributor

No description provided.

@jnavila
Copy link
Member

jnavila commented Oct 9, 2012

You included a commit which modifies the original english text. Can you split your PR into one on full italian and one on english ?

@DavidePastore
Copy link
Contributor Author

How can I do that?

@jnavila
Copy link
Member

jnavila commented Oct 9, 2012

You can rebase -i your master on remote/master and just delete the line of commit da43fe7 so that it no longer appears. Then push -f your master to github.

@DavidePastore
Copy link
Contributor Author

Ok! I did what you suggested, but the problem now is: "Everything up-to-date". In the log list the da43fe7 doesn't exist anymore. What is the problem?

@jnavila
Copy link
Member

jnavila commented Oct 11, 2012

Do you mean that you can not push your new master to github. This is strange if you changed it. Git should at least warn that you are trying to push to a remote ref which was already published.

Moreover, I am suspicious in your changes (see my other mail)

@@ -63,7 +63,7 @@ Ora diciamo che hai aggiunto un nuovo file al tuo progetto, un semplice file REA

$ vim README
$ git status
# On branch master
# On branch MASTER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This listing of branch "MASTER" is strange here. Are you sure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i change it to lowercase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't edit it with the online editor of github. My request falls into a "404 error: this is not the web page you are looking for." And I'm tired of these problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now it works properly.

@DavidePastore
Copy link
Contributor Author

Yes! My new repo has cb595dd code. I changed it. I try git push -f and git push --force but the result is the same.

@jnavila
Copy link
Member

jnavila commented Oct 11, 2012

Well I guess I'll have to cherry-pick your changes. My main issue is that for foreign languages, I can not do very useful reviews.

@DavidePastore
Copy link
Contributor Author

This isn't a problem. You can change to lowercase "MASTER". All my italian files are good. Can you split the commits because I'll go crazy for these problems that consume my days?

@jnavila
Copy link
Member

jnavila commented Oct 11, 2012

Hello back, I pushed a branch DavidePastore on progit/progit with a pick up of your changes. Can you review it before I merge it? Thanks in advance.

@DavidePastore
Copy link
Contributor Author

Hello! :D Ok jnavila! Thanks for your work! I don't know how did you do it but now the work is more simple. Now I edit one thing. What is the next step?

@jnavila
Copy link
Member

jnavila commented Oct 12, 2012

Pulled from cherry-pick.

@jnavila jnavila closed this Oct 12, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants