Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the model I found on the Internet to report an error. #32

Closed
jiaxianghao opened this issue Jun 5, 2023 · 6 comments
Closed

Load the model I found on the Internet to report an error. #32

jiaxianghao opened this issue Jun 5, 2023 · 6 comments

Comments

@jiaxianghao
Copy link

The assert in the toSrgbInternalFormat is called with parameter format of value 3.

@matthew-reid
Copy link
Contributor

In old versions of OpenGL, the internal format value was treated directly as number of color components: 1, 2, 3, or 4.
I assume the asset you're trying to load is using this old technique. I've just added support for it in this commit on the v1.5 branch. You'll have to clone it from git as there's no Skybolt release version for it.

@jiaxianghao
Copy link
Author

I'll try it later.

@jiaxianghao
Copy link
Author

Ok, The problem has been solved

@jiaxianghao
Copy link
Author

I found the toSrgbInternalFormat function are same in v1.3.3 and v1.5.0.In v1.5.0,some model still loading failed.

@jiaxianghao
Copy link
Author

I am using the v1.5.0 tag.

@jiaxianghao
Copy link
Author

I modified the toSrgbInternal function to return GL_SRGB8 when format is 3, and then the model is loaded normally. I don't know if it's reasonable for me to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants