Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding translation editors to YAML metadata #611

Closed
arojascastro opened this issue Sep 29, 2017 · 14 comments · Fixed by #670
Closed

adding translation editors to YAML metadata #611

arojascastro opened this issue Sep 29, 2017 · 14 comments · Fixed by #670

Comments

@arojascastro
Copy link
Contributor

I have been reviewing some tutorials and I found out that our metatada information is not very consistent.

tutorial without original reviewers

sin_revisores_originales

tutorial without translation editor

sin_editor

tutorial with translation editor

traduccion_con_editor

In my opinion, only the last tutorial contains the necessary metadata information.

I am wondering whether is possible to use any validation system for this (Travis?) @mdlincoln @acrymble ?

@arojascastro
Copy link
Contributor Author

By the way the snippet traducción editado por should be traducción editada por (in femenine).

@acrymble
Copy link

Some of the early lessons involving Fred Gibbs didn't have reviewers. That's not inconsistent with what happened. He did the reviewing himself, acting as an editor.

@arojascastro
Copy link
Contributor Author

Ok, but can we validate the metadata about translations? I just want a list of tutorials that do not contain that info... of course I can check out myself but it is time consuming. If we cant do it automatically please let me know and I will.

@mdlincoln
Copy link
Contributor

mdlincoln commented Sep 29, 2017

We do check metadata @arojascastro (#426) however right now translation_editor is not validated, because only one lesson actually had a translation-editor in it. I'll add that field to the checklist now, and then you'll see all the errors for lessons that are missing it.

mdlincoln added a commit that referenced this issue Sep 29, 2017
@mdlincoln
Copy link
Contributor

mdlincoln commented Sep 29, 2017

You can find the list of lessons with missing translation-editor here: https://travis-ci.org/programminghistorian/jekyll

@mdlincoln mdlincoln mentioned this issue Sep 29, 2017
13 tasks
@arojascastro
Copy link
Contributor Author

Super! @mdlincoln

@mdlincoln
Copy link
Contributor

Apologies, the specific build listing the missing YAML is here: https://travis-ci.org/programminghistorian/jekyll/builds/281347660

@arojascastro
Copy link
Contributor Author

@mdlincoln 🔝 💯

@mdlincoln mdlincoln changed the title Validation of metadata? adding translation editors to YAML metadata Oct 3, 2017
@mdlincoln
Copy link
Contributor

@arojascastro Is it possible to add these editors soon? Without having the editor metadata in place, we will keep receiving build errors and it makes other development work difficult.

@arojascastro
Copy link
Contributor Author

@mdlincoln sorry, I can't work on this until Sunday... you may turn it off? Now I know that basically all lessons need that feld. Maybe @vgayolrs and @mariajoafana can help me?

mdlincoln added a commit that referenced this issue Oct 4, 2017
This reverts commit 92d90ec.

Will re-enable once #611 is closed
vgayolrs added a commit that referenced this issue Oct 8, 2017
@arojascastro
Copy link
Contributor Author

arojascastro commented Oct 11, 2017

I am sorry @mdlincoln but I must postpone this tak for some more days.

vgayolrs added a commit that referenced this issue Oct 24, 2017
vgayolrs added a commit that referenced this issue Oct 24, 2017
vgayolrs added a commit that referenced this issue Oct 24, 2017
@mdlincoln
Copy link
Contributor

Hi @arojascastro @vgayolrs what is the current status of this ticket?

@arojascastro
Copy link
Contributor Author

Sorry for the super delay @mdlincoln - this pull request should solve the problem: #666

Please let me know if there is any lesson missing that field yet.

@arojascastro
Copy link
Contributor Author

Thanks @vgayolrs for approving my request. Can @mdlincoln check that Travis validation is good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants