Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logistic-regression.md #3284

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Update logistic-regression.md #3284

merged 5 commits into from
Jun 20, 2024

Conversation

charlottejmc
Copy link
Contributor

@charlottejmc charlottejmc commented Jun 14, 2024

I've changed the formatting in the lesson to use $$ around mathematical formulas.

Closes #3283

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Manager @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • [ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Fix formula formatting using $$
@charlottejmc
Copy link
Contributor Author

This is not rendering in the Netlify preview how I anticipated. I'll come back to this next week!

@miy-h
Copy link

miy-h commented Jun 19, 2024

It looks that the symbol | in math block is parsed as Markdown's table delimiter by kramdown, a Markdown parser used in jekyll. Maybe it is a bug of kramdown, but fixing it is difficult because kramdown is not actively maintained.

Instead, I suggest replacing X|Y with X \vert Y in math block. \vert represents | exactly in TeX and can be rendered by MathJax.

@charlottejmc
Copy link
Contributor Author

Hello @miy-h,

Thank you so much for contributing to this issue. Your solution worked perfectly! We're just fixing a separate build issue before merging this PR, but you can see from the Netlify preview that your suggestion was successful :)

ありがとうございました ✨

@anisa-hawes anisa-hawes self-requested a review June 20, 2024 19:31
Copy link
Contributor

@anisa-hawes anisa-hawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution @miy-h!

+ Thank you @charlottejmc for coordinating.

@charlottejmc charlottejmc merged commit 366f66c into gh-pages Jun 20, 2024
5 checks passed
@charlottejmc charlottejmc deleted the Issue-3283 branch June 20, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix formula formatting in /en/logistic-regression
3 participants