Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercise numeric facet in section 'get to know your data' requires op… #649

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

felixlohmeier
Copy link
Contributor

fix for some issues in lesson "Cleaning Data with OpenRefine":

  • numeric facet in section 'get to know your data' requires option 'parse cell text into numbers, dates, ...' during import
  • number of cells affected in last exercise is 33,008 using OpenRefine 2.7
  • typo (wether --> whether)

…tion 'parse cell text into numbers, dates, ...' during import; number of cells affected in last exercise is 33,008 using OpenRefine 2.7
@mdlincoln
Copy link
Contributor

As you edited this lesson @acrymble I'm putting you in charge of reviewing this PR.

@acrymble
Copy link

acrymble commented Nov 8, 2017

Sorry, but I don't have time to look into this.

@acrymble acrymble removed their assignment Nov 8, 2017
@acrymble acrymble removed their request for review November 8, 2017 15:58
@ianmilligan1
Copy link
Contributor

Could you loop in the authors @acrymble?

@acrymble
Copy link

Done.

@madewild
Copy link

As an author of the lesson, I confirm that the changes proposed by @felixlohmeier are relevant and should be accepted. Thanks for improving this old lesson! :)

Copy link
Contributor

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madewild (author) has approved, and the additions also look great to me as an editor. Thanks all.

@ianmilligan1 ianmilligan1 merged commit f2ffc3f into programminghistorian:gh-pages Nov 13, 2017
felixlohmeier added a commit to felixlohmeier/bibliotheks-und-archivinformatik that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants