-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Ticket for 'Editing Audio with Audacity' #15
Comments
This is a great tutorial! It’s fairly easy to follow and nicely organized, and it contains exactly the right amount of explanation. Its objectives are clearly stated, and it has a consistent model reader in mind throughout the lesson. I’d recommend making the payoff clearer, updating the lesson for the new version of Audacity, and possibly rethinking the layout of step-by-step directions: -The opening could be enhanced by adding a sentence explaining why someone might want to make a podcast or an audio file. |
Ah geez - I didn't realize that Audacity had come out with a new version since I submitted this. Thanks for the great feedback @jswafford - I'll go through and update things accordingly! |
And to answer your question @jswafford - I was using the previous version of Audacity - 2.1.2. Thanks for pointing that out! |
Just a quick note to say that I updated the tutorial with @jswafford's comments. The commit got a bit wonky so that it is a bit difficult to read, but that commit is here. |
The figure syntax for this lesson needs to be updated to reflect the new guidelines posted here, and all image files will need to be placed in a subdirectory. |
@wcaleb done! Thanks - |
thanks @bmw9t and @wcaleb! |
Great tutorial that will be of use to a lot of people! The task accomplished in the lesson is reasonable and the intended audience matches the instruction. I'd recommend adding a few small points of clarification to ease readers through: -Related to downloading the Bach audio file: I suggest explicitly directing readers to download the file first in the "Working with Audacity" section. Looking forward to pointing people to this tutorial in the near future! |
Thanks so much for the comments @celestetvs - I'll push up commits over the course of the next few days and let you know when I'm finished. |
Thank you @celestetvs! These are really great suggestions! @bmw9t as you go through these, a couple additional things to consider. Since this will be a "beginner" level tutorial, in addition to noting that they will need to register for an account, it would be useful to change the link to something link this
so that the file downloads directly, rather than opening in the browser. Another thing that I have noticed (and sorry I didn't catch this earlier) is the difference between mono and stereo recording -- I only notice because own recording came on as two waves, where your examples have one. It is worth mention what is going on there and recommending one or the other. Otherwise, I think we're in good shape! Once you're set, I'll go through for one more round of copyediting, just to make sure we haven't missed anything. |
@jerielizabeth - I just took your advice re: downloading the file automatically. It looks like doing it this way sometimes causes a slight quirk. If you're logged into MusOpen, it downloads as expected. If not logged in, it seems to sometimes download the html for the login page. I assume that is because the login page intervenes before the browser can get to the MP3. What do you think? Still worth doing? I can add some language to the effect of 'if the link doesn't work, make sure you log into MusOpen first' if that helps. The link on the staging server has it download right now, as you suggest. http://programminghistorian.github.io/ph-submissions/lessons/editing-audio-with-audacity.html |
Hmm... that is an interesting quirk and counter to the "make it easier"
Jeri E. Wieringa On Fri, Jul 29, 2016 at 11:58 AM, bmw9t notifications@github.com wrote:
|
The same instructions to right click and "Save Link As" should also work on Windows. |
@jerielizabeth I think I took care of everything now! Let me know next steps. Hopefully I didn't get a little too slaphappy with linking to external resources. |
ok great!! Thanks @bmw9t! I will take one last look for copyediting purposes, but I think we nearly there! My week's been crazy, but I'm hoping for Friday! |
Hi @bmw9t! I think we're ready to go! I made some copy edit in the latest push -- most are minor, but i did move things around in the "how to download" section. You of course have veto power on the edits, so go ahead and look it over. If you're happy, I'll move this over to the main site today! |
@jerielizabeth looks great to me! I made one change to italics. It should be set now. Thanks! Let me know when you send it out and I'll publicize it accordingly. |
Soft publication of "editing audio with audacity" is up at http://programminghistorian.org/lessons/editing-audio-with-audacity. Last chance to make changes before the link goes on the lessons page. |
Congratulations @bmw9t and thank you again to our reviewers @jswafford and @celestetvs ! This lesson is now live at http://programminghistorian.org/lessons/editing-audio-with-audacity. This ends the review process for this lesson! |
The Programming Historian has received the following tutorial on 'Editing Audio with Audacity' by @bmw9t. This lesson is now under review and can be read at:
http://programminghistorian.github.io/ph-submissions/lessons/editing-audio-with-audacity
I will act as editor for the review process. My role is to solicit two reviews from the community and to manage the discussions, which should be held here on this forum. I have already read through the lesson and provided feedback, to which the author has responded.
Members of the wider community are also invited to offer constructive feedback which should post to this message thread, but they are asked to first read our Reviewer Guidelines (http://programminghistorian.org/reviewer-guidelines) and to adhere to our anti-harassment policy (below). We ask that all reviews stop after the second formal review has been submitted so that the author can focus on any revisions. I will make an announcement on this thread when that has occurred.
I will endeavor to keep the conversation open here on Github. If anyone feels the need to discuss anything privately, you are welcome to email me. You can always turn to @ianmilligan1 or @miriamposner if you feel there's a need for an ombudsperson to step in.
Anti-Harassment Policy
_
The text was updated successfully, but these errors were encountered: