Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically roll back when build fail? #28

Open
mouyigang opened this issue Jun 29, 2015 · 2 comments
Open

Automatically roll back when build fail? #28

mouyigang opened this issue Jun 29, 2015 · 2 comments

Comments

@mouyigang
Copy link

I edited my Dockerfile to FROM mysql and obviously it won't work but I exited the session, before I realised the mistake, now I can't log in to that environment any more.

If this kind of situation happens, would it be nice to provide an option to reverse the Dockerfile change to last working state?

And I also wonder how to manually fix this, I attached the main docker instance and went to /data/users/[username]/envs and removed the whole folder named after that environment, didn't help.

@progrium
Copy link
Owner

progrium commented Jul 1, 2015

There's a couple situations here. There's a bad build that will not finish making the image. This should already work fine on failure since the last image will still exist I think. Then there's a mistake that makes the image unusable even though it builds fine. Which one are you talking about?

@mouyigang
Copy link
Author

Sorry for the late response, the later one. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants