Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensibility] Too(?)-tightly coupled #104

Closed
DazWilkin opened this issue Nov 4, 2020 · 5 comments · Fixed by #252
Closed

[Extensibility] Too(?)-tightly coupled #104

DazWilkin opened this issue Nov 4, 2020 · 5 comments · Fixed by #252
Labels
enhancement New feature or request

Comments

@DazWilkin
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Extensibility is tightly-coupled.

Protocol changes require agent, controller and CRD rebuilds and redeployments.

It seems that this system would benefit from being dynamic though I can't provide guidance on how to achieve this beyond it being a good use-case for gRPC.

@kate-goldenring
Copy link
Contributor

Definitely agree. We would love to have discovery protocol handlers to be modularized such that they do not require changes to Akri's core components. We've created a proposal for this here.

@kate-goldenring kate-goldenring added the enhancement New feature or request label Nov 4, 2020
@DazWilkin
Copy link
Contributor Author

DazWilkin commented Nov 5, 2020

Outstanding!

FWIW options 3 and 4 seem to be the most compelling

@DazWilkin
Copy link
Contributor Author

DazWilkin commented Nov 6, 2020

A benefit of option 3 is that you don't prescribe the language used to implement the discovery agent beyond the broad list of languages that have gRPC SDKs.

@DazWilkin
Copy link
Contributor Author

As I explore extending the Agent to support ZeroConf, it (actually the Rust zeronconf crate specifically) requires additional shared libraries. Such additions:

  1. Require revising the Dockerfiles to include the additional packages;
  2. Increase the possible attack surface of the images;
  3. Increase the size of the images;
  4. Possibly contaminate other protocols (dependency mismatch etc.)
  5. May require enterprise security re-ups on auditing, licensing etc.

Example:

zeroconf (0.6.2) requires: xorg-dev, libxcb-shape0-dev, libxcb-xfixes0-dev, clang

@DazWilkin
Copy link
Contributor Author

... and, shared library additions require providing|testing equivalent changes for each platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants