Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

One docker-compose for project #931

Closed
knjk04 opened this issue Feb 15, 2022 · 0 comments · Fixed by #932
Closed

One docker-compose for project #931

knjk04 opened this issue Feb 15, 2022 · 0 comments · Fixed by #932
Assignees
Labels
docker dx Developer experience-related enhancement New feature or improvement of an existing feature request

Comments

@knjk04
Copy link
Member

knjk04 commented Feb 15, 2022

Is your feature request related to a problem? If so, please describe.
We currently have to navigate to the frontend directory to start the frontend container and then navigate to the backend directory to the backend container. We also need an extra two commands.

Describe the solution you'd like
It would be a better developer experience if we kept two separate Dockerfiles (one for the frontend and one backend) with one docker-compose.yml in the root of the project.

This would reduce the number of steps it takes to start the project:

  • Only one docker-compose build, not two
  • One command to start the frontend, backend and db containers
  • Only one docker-compose down command to stop and remove the running containers, not two
  • No need to navigate to the frontend directory and then into the backend directory

Total savings: 5 fewer commands to run everything

Additional context

  • Be sure to read the contributing guidelines first!
  • Discuss your implementation approach with us before we assign you to it
  • Provide us with an estimate on how long you think it will take you to complete
  • Branch from main and set main as the destination branch in your pull request

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

@knjk04 knjk04 added enhancement New feature or improvement of an existing feature request dx Developer experience-related docker labels Feb 15, 2022
@knjk04 knjk04 self-assigned this Feb 15, 2022
@knjk04 knjk04 mentioned this issue Feb 15, 2022
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docker dx Developer experience-related enhancement New feature or improvement of an existing feature request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant