Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

Use sh instead of bash #972

Closed
knjk04 opened this issue Mar 27, 2022 · 2 comments
Closed

Use sh instead of bash #972

knjk04 opened this issue Mar 27, 2022 · 2 comments
Labels
good first issue Good for newcomers refactor Improvement to code (e.g. remove duplication) wontfix This will not be worked on

Comments

@knjk04
Copy link
Member

knjk04 commented Mar 27, 2022

We currently add bash to our Alpine-based image as we use it in our frontend start script.

So that we don't increase the size considerably, use sh instead of bash

Additional context

  • Be sure to read the contributing guidelines first!
  • Discuss your implementation approach with us before we assign you to it
  • Provide us with an estimate on how long you think it will take you to complete
  • Branch from main and set main as the destination branch in your pull request

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

@knjk04 knjk04 added good first issue Good for newcomers refactor Improvement to code (e.g. remove duplication) labels Mar 27, 2022
@stale stale bot added the wontfix This will not be worked on label May 28, 2022
@stale stale bot closed this as completed Jun 4, 2022
@Project-Books Project-Books deleted a comment from stale bot Apr 2, 2023
@knjk04 knjk04 reopened this Apr 2, 2023
@divyeshio
Copy link

Can you please assign this issue to me? I have already opened a PR #996 for it.

@knjk04
Copy link
Member Author

knjk04 commented Apr 10, 2023

Hi @divyeshio,

Unfortunately, I will be archiving this project as I no longer have the time to maintain it. Thanks again!



@knjk04 knjk04 closed this as completed Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers refactor Improvement to code (e.g. remove duplication) wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants