Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Add extra lint/validators for cluster XMLs #30749

Open
andy31415 opened this issue Nov 30, 2023 · 1 comment
Open

[CI/CD] Add extra lint/validators for cluster XMLs #30749

andy31415 opened this issue Nov 30, 2023 · 1 comment
Labels
CI/CD improvements Improvements to our CI/CD pipelines

Comments

@andy31415
Copy link
Contributor

andy31415 commented Nov 30, 2023

We currently do not validate XML for clusters at all for the chip XMLs that reside in https://github.com/project-chip/connectedhomeip/tree/master/src/app/zap-templates/zcl/data-model/chip

In theory we have https://github.com/project-chip/zap/blob/master/zcl-builtin/shared/schema/zcl.xsd that can validate the schema. Should figure out how zap-cli could be used to validate this or if not, use the xsd from the zap repo itself (even though that may be a version mismatch).

We also likely want some extra validation for some common typos (like forcing casing on things), to avoid PRs like #30740 and #29706 needing to be done over and over again.

This may need splitting into separate tasks:

  • add validation for xsd (and this will find issues that need fixing)
  • add casing enforcement for some standard types (either in matter or in xml files)
@andy31415 andy31415 added the CI/CD improvements Improvements to our CI/CD pipelines label Nov 30, 2023
@andy31415 andy31415 changed the title [CI/CD] Add extra lint/validators for XML clusters [CI/CD] Add extra lint/validators for cluster XMLs Nov 30, 2023
@andy31415
Copy link
Contributor Author

we should catch typos such as found by #31015

@kliao-csa kliao-csa self-assigned this Feb 1, 2024
@kliao-csa kliao-csa removed their assignment Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD improvements Improvements to our CI/CD pipelines
Projects
Status: No status
Development

No branches or pull requests

2 participants