Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Conformance for DataVersionFilter and EventFilters wrong for Read/Subscribe? #33816

Closed
Apollon77 opened this issue Jun 9, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation needs triage

Comments

@Apollon77
Copy link
Contributor

Apollon77 commented Jun 9, 2024

Documentation issues

The specification for Read and Subscribe define the Conformance for DataVersionFilter as "Mandatory if AttributeRequests exists" and same for the EventReports for the EventRequests.

When I know correctly how it is requested by common controllers these days (verified with Apple and Google for Read) - and so must be implemented that way in chip? - then the conformance for DataVersionFilter and EventFilters should be more "optional if other field is set", so more like "[AttributeRequests]" instead "AttributeRequests".

In fact the Message definitionis in e.g. 10.7.2 mark the fields as "optional", should then not also the model details have that?

Platform

No response

Anything else?

No response

@Apollon77 Apollon77 added documentation Improvements or additions to documentation needs triage labels Jun 9, 2024
@Apollon77
Copy link
Contributor Author

Ok, infos in message encoding tells that it should be treated as empty list if not existient ... so ok ... formally correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation needs triage
Projects
None yet
Development

No branches or pull requests

1 participant