Initial Outline #1

woody-apple · 2020-03-03T18:05:28Z

A bare skeleton for to start with, along with:
• Readme
• License
• Code of Conduct
• Style Guide
• Simple test source code
• Build checks out (and doesn’t run yet) on Pull Request and Push
• clang-tidy runs on Pull Requests
• clang-format starting point

Note: Once this account is open, I recommend turning on on these marketplace extensions:
•restyled.io (config file placed here).
• LGTM - https://github.com/marketplace/lgtm - Good security analysis
• Codacy - https://github.com/marketplace/codacy - Good security analysis/code pattern review

CONTRIBUTING.md

README.md

gerickson · 2020-03-03T18:15:26Z

actions/clang-tidy/Dockerfile

@@ -0,0 +1,8 @@
+FROM ubuntu:xenial


Will CHIP be reliant on Docker? If so, why? Personally, I'd be opposed to this. Anything that increases the number of prerequisites I need to install on my machine to start using and playing with CHIP is a potential engagement barrier.

What would stand in our way of out of the box builds being supported on both Mac OS X and Linux with no Docker container?

This is just a standard GitHub action, this doesn't run in your device, it runs in the the GitHub cloud, and only there. In this case, it's running clang-tidy on PR request submittals and updates. You can learn more about how these run here: https://help.github.com/en/actions

How do / can I run clang-tidy locally on my MacBook Pro? Is that mechanism different than what we use for CI?

There is no current way to run clang-tidy on local, at present. That's a great suggestion for (I'd argue) a future change (maybe make an issue for this?)

In the openweave-core and openthread build system, both based on nlbuild-autotools (GNU autotools), two project targets are supported 'make pretty' and 'make pretty-check'. It's up to the project integrator to decide what actions and tools to employ to support those targets.

Happy to absolutely do that. I've opened a new issue here to cover that!

docs/STYLE_GUIDE.md

gerickson

Some minor changes to be addressed, mostly around "third_party" and "actions". The rest warrant discussion either pre- or post-commit.

gerickson

I think the clang-tidy / pretty / pretty-check discussion worth having, but this is a solid start.

hawk248 · 2020-03-03T21:47:22Z

Approved ...

chrisdecenzo

Looks good, thanks

robszewczyk · 2020-03-03T22:02:25Z

CODE_OF_CONDUCT.md

@@ -0,0 +1,77 @@
+


Need to double check whether this was the officially approved code of conduct for project CHIP. no reason to block on this, but we need to get the right one in before we throw the repository to be public

Fix Darwin Builds for 02 multi session support

Syncing fork to main repo

WARNING: ThreadSanitizer: race on NSMutableDictionary (pid=72050) Modifying access of NSMutableDictionary at 0x7b0800149020 by thread T7: #0 -[__NSDictionaryM setObject:forKey:] <null>:2 (CoreFoundation:x86_64+0x40d4e) project-chip#1 -[MTRXPCListenerSample listener:shouldAcceptNewConnection:] MTRXPCListenerSampleTests.m:116 (MatterTests:x86_64+0x48437b) project-chip#2 service_connection_handler_make_connection <null>:2 (Foundation:x86_64+0xdea93) Previous modifying access of NSMutableDictionary at 0x7b0800149020 by thread T4: #0 -[__NSDictionaryM removeObjectForKey:] <null>:2 (CoreFoundation:x86_64+0x6cd6d) project-chip#1 __59-[MTRXPCListenerSample listener:shouldAcceptNewConnection:]_block_invoke MTRXPCListenerSampleTests.m:119 (MatterTests:x86_64+0x484630)

WARNING: ThreadSanitizer: race on NSMutableDictionary (pid=72050) Modifying access of NSMutableDictionary at 0x7b0800149020 by thread T7: #0 -[__NSDictionaryM setObject:forKey:] <null>:2 (CoreFoundation:x86_64+0x40d4e) #1 -[MTRXPCListenerSample listener:shouldAcceptNewConnection:] MTRXPCListenerSampleTests.m:116 (MatterTests:x86_64+0x48437b) #2 service_connection_handler_make_connection <null>:2 (Foundation:x86_64+0xdea93) Previous modifying access of NSMutableDictionary at 0x7b0800149020 by thread T4: #0 -[__NSDictionaryM removeObjectForKey:] <null>:2 (CoreFoundation:x86_64+0x6cd6d) #1 __59-[MTRXPCListenerSample listener:shouldAcceptNewConnection:]_block_invoke MTRXPCListenerSampleTests.m:119 (MatterTests:x86_64+0x484630)

…ist". (#29666) The typical failure there looks like this: ==29620==ERROR: LeakSanitizer: detected memory leaks Direct leak of 88 byte(s) in 1 object(s) allocated from: #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12) #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789) #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db) #3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa) #4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8) #5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1) #6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44) #7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343) #8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992) #9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7) #10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894) #11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e) #12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac) #13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25) #14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2) #15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6) #16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603) #17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81) #18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659) #19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d) #20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c) #21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)

* pw_unit_test migration: lib support batch #1 * apply restyled patch * integrate comments

Initial Outline

c9bbb25

woody-apple requested review from anush-apple, clapre, gerickson and robszewczyk March 3, 2020 18:05

gerickson reviewed Mar 3, 2020

View reviewed changes

CONTRIBUTING.md Show resolved Hide resolved

gerickson reviewed Mar 3, 2020

View reviewed changes

README.md Show resolved Hide resolved

gerickson reviewed Mar 3, 2020

View reviewed changes

docs/STYLE_GUIDE.md Show resolved Hide resolved

gerickson reviewed Mar 3, 2020

View reviewed changes

woody-apple requested a review from gerickson March 3, 2020 18:28

terafin added 2 commits March 3, 2020 10:40

Moving the location of github actions per feedback

85fd324

Pointing the clang-tidy.yaml to the correct location

916b794

gerickson approved these changes Mar 3, 2020

View reviewed changes

woody-apple mentioned this pull request Mar 3, 2020

Run clang-tidy locally #2

Closed

woody-apple requested review from chrisdecenzo and hawk248 March 3, 2020 21:45

anush-apple approved these changes Mar 3, 2020

View reviewed changes

hawk248 approved these changes Mar 3, 2020

View reviewed changes

chrisdecenzo approved these changes Mar 3, 2020

View reviewed changes

robszewczyk approved these changes Mar 3, 2020

View reviewed changes

robszewczyk merged commit c0e87a3 into project-chip:master Mar 3, 2020

bhaskar-apple mentioned this pull request Apr 10, 2020

Implement openSSL based AES-256-CCM #334

Merged

rwalker-apple mentioned this pull request Apr 14, 2020

Integrate mbedTLS library to CHIP #357

Closed

emargolis mentioned this pull request Apr 27, 2020

Missing openSSL based ECDH implementation #420 #494

Merged

restyled-io bot pushed a commit that referenced this pull request Jun 23, 2020

Merge pull request #1 from sagar-apple/02_multi_session_support

d70f74f

Fix Darwin Builds for 02 multi session support

restyled-io bot pushed a commit that referenced this pull request Jun 24, 2020

Merge pull request #1 from project-chip/master

924f3c3

Syncing fork to main repo

bhaskar-apple mentioned this pull request Jul 23, 2020

Make debug printing work again in Silicon Labs ZigbeePro code #1709

Merged

github-actions bot mentioned this pull request Jul 30, 2020

ESP32 - Retrieve discriminator and setupPINCode from the Configuratio… #1918

Merged

andygallay-silabs referenced this pull request in andygallay-silabs/connectedhomeip-silabs May 30, 2023

Clean up #1 for AppTask

8e8c1f1

satyajitanand mentioned this pull request Jun 21, 2023

[Platform] Difficulty in building Android CHIPTool #27374

Open

KumhoElectricLJH mentioned this pull request Jun 26, 2023

[1.1] Connection failure error during DFU over Matter (nRF52840) #27460

Closed

yicheng810 pushed a commit to yicheng810/connectedhomeip that referenced this pull request Jun 27, 2023

BTSDK-6720 Apply Restylers made fixes. (project-chip#1)

eb19324

sumaky mentioned this pull request Jul 24, 2023

[CERT-TEST-FAILURE] TC-GRPKEY-2.1 key-set-write Commnad fails when EpochStartTime0 is set to 0 #28222

Closed

yunhanw-google mentioned this pull request Jul 28, 2023

[BUG] thread network provisioning crash in cirque test #28352

Open

Allen-Guof mentioned this pull request Aug 14, 2023

[1.1][Android] After invoke ChipDeviceController.shutdownCommissioning, every thing is not worked. #28681

Open

Guotao-Aqara mentioned this pull request Aug 23, 2023

[BUG] Device can't resume a persisted subscription when the device restarts(like power down) unexpectedly #28825

Closed

netscell mentioned this pull request Sep 5, 2023

[BUG] crash in libCHipcontroller.so #29061

Closed

M201370367 mentioned this pull request Oct 25, 2023

[BUG] crash: JNI NewByteArray called with pending exception java.lang.AbstractMethodError #29997

Open

tehampson mentioned this pull request Nov 28, 2023

Update CommandHandler to support batch commands #30614

Merged

yunhanw-google mentioned this pull request Dec 12, 2023

[1.3] Persistent Subscription crash in LIT example app #30944

Open

joonhaengHeo mentioned this pull request Dec 20, 2023

[BUG][Android] Crash Android chip-tool when reading event #31127

Closed

pgatti86 mentioned this pull request Dec 22, 2023

[BUG] [Android] crash happens when device reboot #30624

Closed

MrLiuYunPing mentioned this pull request Dec 28, 2023

[SVE] [Android] Crash on Android13 #22440

Closed

vatsalghelani-csa mentioned this pull request Feb 1, 2024

[CI/CD] Standardise argument order in invoking python integration tests during CI #31816

Merged

yunhanw-google mentioned this pull request Feb 1, 2024

Remove dependency of InteractionModelEngine in CommandHandler #31830

Merged

shuiYe-704265085 mentioned this pull request Feb 4, 2024

[1.2] Failed to resolve service '75E232F7505D0C92': 3 #31899

Closed

Dhirav-Shah mentioned this pull request Feb 14, 2024

[1.2] Chip-tool Android Application crashed when tried to implement device to device binding #31989

Closed

salvio96 mentioned this pull request Feb 21, 2024

[1.2] All-cluster-app pairing with chip tool #32037

Closed

JasonClark2 mentioned this pull request Apr 3, 2024

[Test Failed] [BUG] When I pair with a matter device, it sometimes crashes. I'm sure I'm using the same method, but it crashes every now and then. The second time the pairing succeeds, #32826

Open

Alami-Amine added a commit to Alami-Amine/connectedhomeip that referenced this pull request Apr 22, 2024

pw_unit test conversion: lib support batch project-chip#1

2f70ffb

Alami-Amine added a commit to Alami-Amine/connectedhomeip that referenced this pull request Apr 22, 2024

pw_unit_test migration: lib support batch project-chip#1

1b50a31

andy31415 pushed a commit that referenced this pull request Apr 24, 2024

pw_unit_test migration: lib support batch #1 (#33091)

3380876

* pw_unit_test migration: lib support batch #1 * apply restyled patch * integrate comments

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial Outline #1

Initial Outline #1

woody-apple commented Mar 3, 2020

gerickson Mar 3, 2020

woody-apple Mar 3, 2020

gerickson Mar 3, 2020

woody-apple Mar 3, 2020

gerickson Mar 3, 2020

woody-apple Mar 3, 2020

gerickson left a comment

gerickson left a comment

hawk248 commented Mar 3, 2020

chrisdecenzo left a comment

robszewczyk Mar 3, 2020

Initial Outline #1

Initial Outline #1

Conversation

woody-apple commented Mar 3, 2020

gerickson Mar 3, 2020

Choose a reason for hiding this comment

woody-apple Mar 3, 2020

Choose a reason for hiding this comment

gerickson Mar 3, 2020

Choose a reason for hiding this comment

woody-apple Mar 3, 2020

Choose a reason for hiding this comment

gerickson Mar 3, 2020

Choose a reason for hiding this comment

woody-apple Mar 3, 2020

Choose a reason for hiding this comment

gerickson left a comment

Choose a reason for hiding this comment

gerickson left a comment

Choose a reason for hiding this comment

hawk248 commented Mar 3, 2020

chrisdecenzo left a comment

Choose a reason for hiding this comment

robszewczyk Mar 3, 2020

Choose a reason for hiding this comment