Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom-metrics-api #619

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Remove custom-metrics-api #619

merged 1 commit into from
Sep 4, 2023

Conversation

ChristianZaccaria
Copy link
Contributor

Issue link

Closes #608

What changes have been made

Removed custom metrics API implementation, and the corresponding APIService and RBAC resources, while keeping the external metrics API.

Verification steps

e2e tests should pass.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • e2e tests

@ChristianZaccaria ChristianZaccaria requested review from astefanutti and removed request for metalcycling and dmatch01 August 31, 2023 07:11
@astefanutti
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 31, 2023
@openshift-ci openshift-ci bot removed the lgtm label Aug 31, 2023
@asm582
Copy link
Member

asm582 commented Aug 31, 2023

build errored with error from Kubelet: Error: context deadline exceeded, performing manual restart

@asm582
Copy link
Member

asm582 commented Aug 31, 2023

build errored with error from Kubelet: Error: context deadline exceeded, performing manual restart

@ChristianZaccaria same issue again, I would run tests locally and see why MCAD image deployment is failing.

@ChristianZaccaria
Copy link
Contributor Author

build errored with error from Kubelet: Error: context deadline exceeded, performing manual restart

@ChristianZaccaria same issue again, I would run tests locally and see why MCAD image deployment is failing.

@asm582 Thanks for advising me, I will attempt this and see what I can find, thank you 👍

@ChristianZaccaria ChristianZaccaria force-pushed the remove-custom-metrics-api branch 2 times, most recently from bf9b90f to 6d1c325 Compare September 1, 2023 16:54
@astefanutti
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 4, 2023
@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit ce73445 into project-codeflare:main Sep 4, 2023
2 checks passed
@ChristianZaccaria ChristianZaccaria mentioned this pull request Sep 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti Awaiting requested review from astefanutti

Assignees

@astefanutti astefanutti

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove custom metrics API implementation (keep external metrics)
4 participants
@ChristianZaccaria @astefanutti @asm582 @openshift-merge-robot