Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlabhook] Wrong --repository-url for satis/build #99

Closed
sacesare opened this issue May 15, 2019 · 1 comment
Closed

[gitlabhook] Wrong --repository-url for satis/build #99

sacesare opened this issue May 15, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@sacesare
Copy link

There's a problem with
--repository-url="%s"

since it result shell execution error:

In PackageSelection.php line 195:
                                                                               
  [InvalidArgumentException]                                                   
  Specified repository url ""http://gitlab.my.ru/test/pi_prj.git"" does  
   not exist.                                                                  
                                                                               

Exception trace:
 Composer\Satis\PackageSelection\PackageSelection->select() at /var/www/satisfy/vendor/composer/satis/src/Console/Command/BuildCommand.php:189
 Composer\Satis\Console\Command\BuildCommand->execute() at /var/www/satisfy/vendor/symfony/console/Command/Command.php:251
 Symfony\Component\Console\Command\Command->run() at /var/www/satisfy/vendor/symfony/console/Application.php:946
 Symfony\Component\Console\Application->doRunCommand() at /var/www/satisfy/vendor/symfony/console/Application.php:248
 Symfony\Component\Console\Application->doRun() at /var/www/satisfy/vendor/composer/satis/src/Console/Application.php:56
 Composer\Satis\Console\Application->doRun() at /var/www/satisfy/vendor/symfony/console/Application.php:148
 Symfony\Component\Console\Application->run() at /var/www/satisfy/bin/satis:26

build [--repository-url [REPOSITORY-URL]] [--repository-strict] [--no-html-output] [--skip-errors] [--stats] [--] [<file>] [<output-dir>] [<packages>]...

command line is:
'/var/www/satisfy/bin/satis' 'build' '/var/www/satisfy/satis.json' 'web' '--skip-errors' '--no-ansi' '--verbose' '--repository-url="http://gitlab.my.ru/test/pi_prj.git"' '--repository-strict'

and
'--repository-url="http://gitlab.my.ru/test/pi_prj.git"' is not correctly interpreted by shell(Process composent).

simple fix-remove double quotes:
--repository-url=%s

@ramunasd ramunasd added the bug label May 16, 2019
@ramunasd ramunasd added this to the 3.2 milestone May 16, 2019
@ramunasd ramunasd self-assigned this May 16, 2019
@ramunasd
Copy link
Collaborator

ramunasd commented May 25, 2019

@sacesare please check if everything works fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants