Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change / Add confirmation for player ID when giving them a buy menu #192

Closed
Ghavio1516 opened this issue Mar 4, 2024 · 2 comments
Closed

Comments

@Ghavio1516
Copy link

Describe the bug
Hello, i would like to know if you guys could add like a confirmation for the ID section of the player because at the moment the moment i enter 1 number it automatically searches for that person target ID.

lets just say i want to give a house to player with id 13, the moment i clicked 1 on the ID menu it sends the buy menu to player ID 1 which i dont want
To Reproduce
Steps to reproduce the behavior:

  1. Open /Housing
  2. Click on manage property (already owned / freshly created property)
  3. Input Target ID for finalize sale
  4. See problem

Expected behavior
When i input 13, it will not send the buy menu to player ID 1

Screenshots
i can see it always triggered the event when i input any number
image
image
image

Additional context

@xFutte
Copy link
Member

xFutte commented Mar 8, 2024

@Ghavio1516 Good suggestion. Feel free to add it yourself by following this:

  • Change it so it doesn't trigger it on input change
  • Add a button that triggers the JavaScript function to show a confirmation dialogue being a promise to be resolved after pressing confirm or cancel. When hitting confirm, resolve the promise and send the callback to the lua as already done.
  • Make a pull request

Remember that everything has to align with the rest of the styling.

Happy development.

@complexza
Copy link
Member

complexza commented Apr 6, 2024

Project-Sloth/ps-realtor#33
You can check this out / update your realtor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants