Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to delete all completed tasks in one go #90

Closed
knightcube opened this issue Jun 18, 2018 · 13 comments · Fixed by #349
Closed

An option to delete all completed tasks in one go #90

knightcube opened this issue Jun 18, 2018 · 13 comments · Fixed by #349

Comments

@knightcube
Copy link
Member

  • Give the user to delete all completed tasks with one button.
  • SnackBar for undoing it should also be made.
@brijeshshah13
Copy link
Contributor

@knightcube @Swati4star Is this option to be provided as a menu item in the top right corner?

@Swati4star
Copy link
Member

Yes

@brijeshshah13
Copy link
Contributor

@Swati4star Should it be inside the drop-down menu (3 dots icon) or directly outside?

@Swati4star
Copy link
Member

Swati4star commented Jun 24, 2018

directly outside. (as this would be the only option right now)

@brijeshshah13
Copy link
Contributor

brijeshshah13 commented Jun 25, 2018

@Swati4star How about we display an AlertDialog before deleting all the tasks instead of the Snackbar as it reduces the complexity as well as the overhead of temporary storing the records of the tasks from the table.

@Swati4star
Copy link
Member

@brijeshshah13

  1. Show the confirmation dialog before deleting the tasks
  2. But, the option to undo this should also be there. and snackbar is the best option for this.

@brijeshshah13
Copy link
Contributor

@Swati4star Can we divide this issue into the following sub-tasks, each of cakewalk level?

  1. Display confirmation dialog and delete the tasks.
  2. Display Snackbar to provide the Undo functionality

Because the second one is taking some time.

@knightcube
Copy link
Member Author

knightcube commented Jun 25, 2018

I dont think we should do that because this issue has the intermediate label and breaking it into two separate cakewalk issues would ultimately add upto 20 points anyway.

@brijeshshah13
Copy link
Contributor

@knightcube I agree. But the second requires some time, however, the first one I've already implemented. We can atleast that functionality right away.

@Swati4star
Copy link
Member

I agree with @knightcube
Take your time & implement both the functionalities together.

@knightcube
Copy link
Member Author

knightcube commented Jun 28, 2018

Are you working on this issue @brijeshshah13?

@brijeshshah13
Copy link
Contributor

@knightcube I already working on an another one. It's up for grabs 👍

@aayushinigam
Copy link
Member

Taking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants